From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andrew Morton <akpm@osdl.org>
Cc: David Howells <dhowells@redhat.com>,
torvalds@osdl.org, keyrings@linux-nfs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Keys: Add possessor permissions to keys
Date: Wed, 21 Sep 2005 13:47:14 -0400 [thread overview]
Message-ID: <1127324834.11109.26.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20050921101558.7ad7e7d7.akpm@osdl.org>
on den 21.09.2005 Klokka 10:15 (-0700) skreiv Andrew Morton:
> > + if (PTR_ERR(key_ref) != -EAGAIN) {
> > + if (IS_ERR(key_ref))
> > + key = key_deref(key_ref);
> > + else
> > + key = ERR_PTR(PTR_ERR(key_ref));
> > + break;
> > + }
> > + }
>
> That's getting a bit intimate with how IS_ERR and PTR_ERR are implemented
> but I guess we're unlikely to change that.
Shouldn't that test for IS_ERR(key_ref) be inverted?
Cheers,
Trond
next prev parent reply other threads:[~2005-09-21 17:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5378.1127211442@warthog.cambridge.redhat.com>
2005-09-21 14:48 ` David Howells
2005-09-21 15:05 ` Linus Torvalds
2005-09-21 15:44 ` David Howells
2005-09-21 17:15 ` Andrew Morton
2005-09-21 17:47 ` Trond Myklebust [this message]
2005-09-21 18:36 ` David Howells
2005-09-21 18:29 ` David Howells
2005-09-21 18:45 ` Andrew Morton
2005-09-21 18:56 ` Linus Torvalds
2005-09-22 10:00 ` David Howells
2005-10-03 4:43 ` [Keyrings] " Kyle Moffett
2005-09-21 19:23 ` James Morris
2005-09-21 18:33 ` [PATCH] Keys: Add possessor permissions to keys [try #2] David Howells
2005-09-28 16:03 ` [PATCH] Keys: Add possessor permissions to keys [try #3] David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127324834.11109.26.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®