mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: William D Waddington <william.waddington@beezmo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFClue] pci_get_device, new driver model
Date: Fri, 07 Oct 2005 18:28:31 +0100	[thread overview]
Message-ID: <1128706111.18867.8.camel@localhost.localdomain> (raw)
In-Reply-To: <43469FB8.50303@beezmo.com>

On Gwe, 2005-10-07 at 09:18 -0700, William D Waddington wrote:
> If I convert to pci_get_device, it looks like subsequent calls in the
> loop "put" the previously "gotten" device.  I need the pci_dev struct
> to persist for later use (DMA, etc).  Do I take an additional bump to
> the ref count for each board found before looping, and "put" each when
> the driver is unloaded?

If you are saving the pci device point then yes you should. If you are
using pci_module_init() and the hotplug interface instead then it may
not be neccessary.

> If I just give in to the new driver model how/when do I associate
> instance/minor numbers with boards found?  Is it ever possible for
> ordinary PCI boards to be (logically) removed and re-added w/out
> removing the driver?  If so, how to maintain association between
> a particular board and minor number?

Its up to you how you implement this. One requirement I suspect would be
that the boards have unique serial numbers. Most drivers do not retain
state if someone unplugs a board, moves it and plugs it back in. Instead
they report the old device as "gone" and let user space sort it out


  reply	other threads:[~2005-10-07 17:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-07 16:18 William D Waddington
2005-10-07 17:28 ` Alan Cox [this message]
2005-10-07 17:18   ` William D Waddington
2005-10-07 18:36     ` Alan Cox
2005-10-07 21:45 ` Greg KH
2005-10-07 22:03   ` Greg KH
2005-10-07 22:04     ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2005-10-07 15:56 William D Waddington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1128706111.18867.8.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=william.waddington@beezmo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome