From: Arjan van de Ven <arjan@infradead.org>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: linux-kernel@vger.kernel.org, "'Jens Axboe'" <axboe@suse.de>
Subject: Re: [patch] optimize disk_round_stats
Date: Fri, 14 Oct 2005 12:19:46 +0200 [thread overview]
Message-ID: <1129285187.2873.7.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200510131919.j9DJJkg07781@unix-os.sc.intel.com>
On Thu, 2005-10-13 at 12:19 -0700, Chen, Kenneth W wrote:
> Following the same idea, it occurs to me that we should only update
> disk stat when "now" is different from disk->stamp. Otherwise, we
> are again needlessly adding zero to the stats.
have you measured this?
Conditionals in code are not free, so it might well be more expensive...
next prev parent reply other threads:[~2005-10-14 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 19:19 Chen, Kenneth W
2005-10-13 19:22 ` Jens Axboe
2005-10-14 10:19 ` Arjan van de Ven [this message]
2005-10-14 19:16 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129285187.2873.7.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=axboe@suse.de \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®