From: "Ronald S. Bultje" <rbultje@ronald.bitfreak.net>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, shadowlord@utanet.at,
mjpeg-developer@lists.sourceforge.net
Subject: [PATCH / 2.6.13.4] fix black/white-only svideo input in vpx3220 decoder
Date: Sat, 15 Oct 2005 13:38:18 -0400 [thread overview]
Message-ID: <1129397898.2684.6.camel@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
Hi,
attached patch fixes the fact that the svideo input will only give input
in black/white in some circumstances. Reason is that in the PCI
controller driver (zr36067), after setting input, we reset norm, which
overwrites the input register with the default. This patch makes it
always set the correct value for the input when changing norm.
Patch is against 2.6.13.4 because I couldn't find a pre-made
2.6.14-current tarball to generate the patch against. Shouldn't matter
still, since the vpx3220 driver didn't change much in between, afaik.
Signed-off-by: Ronald S. Bultje <rbultje@ronald.bitfreak.net>
Cheers,
Ronald
[-- Attachment #2: vpx3220-color-svideo.patch --]
[-- Type: text/x-patch, Size: 760 bytes --]
--- linux-2.6.13.4/drivers/media/video/vpx3220-old.c 2005-10-15 13:34:29.000000000 -0400
+++ linux-2.6.13.4/drivers/media/video/vpx3220.c 2005-10-15 13:34:40.000000000 -0400
@@ -410,6 +410,12 @@
case DECODER_SET_NORM:
{
int *iarg = arg, data;
+ int temp_input;
+
+ /* Here we back up the input selection because it gets
+ overwritten when we fill the registers with the
+ choosen video norm */
+ temp_input = vpx3220_fp_read(client, 0xf2);
dprintk(1, KERN_DEBUG "%s: DECODER_SET_NORM %d\n",
I2C_NAME(client), *iarg);
@@ -449,6 +455,10 @@
}
decoder->norm = *iarg;
+
+ /* And here we set the backed up video input again */
+ vpx3220_fp_write(client, 0xf2, temp_input | 0x0010);
+ udelay(10);
}
break;
reply other threads:[~2005-10-15 17:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129397898.2684.6.camel@localhost.localdomain \
--to=rbultje@ronald.bitfreak.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjpeg-developer@lists.sourceforge.net \
--cc=shadowlord@utanet.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome