From: "Ronald S. Bultje" <rbultje@ronald.bitfreak.net>
To: akpm@osdl.org
Cc: casteyde.christian@free.fr, linux-kernel@vger.kernel.org,
mjpeg-developer@lists.sourceforge.net
Subject: [PATCH / 2.6.13.4] fix vpx3220 offset issue in SECAM
Date: Sat, 15 Oct 2005 15:18:14 -0400 [thread overview]
Message-ID: <1129403894.2684.10.camel@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
Hi,
attached patch fixes bug #5404 in kernel bugzilla; it basically updates
the vpx3220 initialization tables with some newer values that we've had
in CVS for a while (and that, for some reason, never ended up in the
kernel... must've gotten lost). Those fix a ~16 pixels noise at the top
of the picture in at least SECAM, although (now that I think about it)
PAL was probably affected, also.
Same as previous patch, it's against 2.6.13.4 because I can't find a
full 2.6.14-current tarball to generate it against. Should apply just
fine.
Signed-off-by: Ronald S. Bultje <rbultje@ronald.bitfreak.net>
Cheers,
Ronald
[-- Attachment #2: vpx3220-fix-offset.patch --]
[-- Type: text/x-patch, Size: 2371 bytes --]
--- linux-2.6.13.4/drivers/media/video/vpx3220-old.c 2005-10-10 14:54:29.000000000 -0400
+++ linux-2.6.13.4/drivers/media/video/vpx3220.c 2005-10-15 13:24:53.000000000 -0400
@@ -203,7 +203,7 @@
0x8c, 640, /* Horizontal length */
0x8d, 640, /* Number of pixels */
0x8f, 0xc00, /* Disable window 2 */
- 0xf0, 0x173, /* 13.5 MHz transport, Forced
+ 0xf0, 0x73, /* 13.5 MHz transport, Forced
* mode, latch windows */
0xf2, 0x13, /* NTSC M, composite input */
0xe7, 0x1e1, /* Enable vertical standard
@@ -212,38 +212,36 @@
static const unsigned short init_pal[] = {
0x88, 23, /* Window 1 vertical begin */
- 0x89, 288 + 16, /* Vertical lines in (16 lines
+ 0x89, 288, /* Vertical lines in (16 lines
* skipped by the VFE) */
- 0x8a, 288 + 16, /* Vertical lines out (16 lines
+ 0x8a, 288, /* Vertical lines out (16 lines
* skipped by the VFE) */
0x8b, 16, /* Horizontal begin */
0x8c, 768, /* Horizontal length */
0x8d, 784, /* Number of pixels
* Must be >= Horizontal begin + Horizontal length */
0x8f, 0xc00, /* Disable window 2 */
- 0xf0, 0x177, /* 13.5 MHz transport, Forced
+ 0xf0, 0x77, /* 13.5 MHz transport, Forced
* mode, latch windows */
0xf2, 0x3d1, /* PAL B,G,H,I, composite input */
- 0xe7, 0x261, /* PAL/SECAM set to 288 + 16 lines
- * change to 0x241 for 288 lines */
+ 0xe7, 0x241, /* PAL/SECAM set to 288 lines */
};
static const unsigned short init_secam[] = {
- 0x88, 23 - 16, /* Window 1 vertical begin */
- 0x89, 288 + 16, /* Vertical lines in (16 lines
+ 0x88, 23, /* Window 1 vertical begin */
+ 0x89, 288, /* Vertical lines in (16 lines
* skipped by the VFE) */
- 0x8a, 288 + 16, /* Vertical lines out (16 lines
+ 0x8a, 288, /* Vertical lines out (16 lines
* skipped by the VFE) */
0x8b, 16, /* Horizontal begin */
0x8c, 768, /* Horizontal length */
0x8d, 784, /* Number of pixels
* Must be >= Horizontal begin + Horizontal length */
0x8f, 0xc00, /* Disable window 2 */
- 0xf0, 0x177, /* 13.5 MHz transport, Forced
+ 0xf0, 0x77, /* 13.5 MHz transport, Forced
* mode, latch windows */
0xf2, 0x3d5, /* SECAM, composite input */
- 0xe7, 0x261, /* PAL/SECAM set to 288 + 16 lines
- * change to 0x241 for 288 lines */
+ 0xe7, 0x241, /* PAL/SECAM set to 288 lines */
};
static const unsigned char init_common[] = {
reply other threads:[~2005-10-15 19:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129403894.2684.10.camel@localhost.localdomain \
--to=rbultje@ronald.bitfreak.net \
--cc=akpm@osdl.org \
--cc=casteyde.christian@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mjpeg-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome