From: Kumar Gala <galak@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: ananth@in.ibm.com,
Linux Kernel list <linux-kernel@vger.kernel.org>,
prasanna@in.ibm.com, anil.s.keshavamurthy@intel.com,
"David S. Miller" <davem@davemloft.net>,
Paul Mackerras <paulus@samba.org>,
masami.hiramatsu.pt@hitachi.com
Subject: Re: [PATCH] kprobes: Fix compiler warning
Date: Tue, 30 Jan 2007 01:12:17 -0600 [thread overview]
Message-ID: <112DEBE1-0765-40DC-B8FD-75DE7336312A@kernel.crashing.org> (raw)
In-Reply-To: <8DAAF0FE-E76A-4C1F-94B7-36BE839EA6BE@kernel.crashing.org>
On Jan 30, 2007, at 1:05 AM, Kumar Gala wrote:
>
> On Jan 29, 2007, at 11:55 PM, Ananth N Mavinakayanahalli wrote:
>
>> On Mon, Jan 29, 2007 at 11:43:33PM -0600, Kumar Gala wrote:
>>> On ppc the compiler gripes about:
>>>
>>> kernel/kprobes.c: In function 'collect_garbage_slots':
>>> kernel/kprobes.c:215: warning: comparison is always false due to
>>> limited
>>> range of data type
>>>
>>> The compiler ends up optimizing away the test since char's are
>>> unsigned on
>>> ppc.
>>
>> Kumar,
>>
>> Masami fixed this last week:
>>
>> http://marc.theaimsgroup.com/?l=linux-kernel&m=116968723823366&w=2
>>
>> Patch currently in -mm.
>>
>> Thanks,
>> Ananth
>
> Cool, Masami's patch looks far more complete.
Andrew,
What are your thoughts on forward Masami patch to Linus for 2.6.20
since it fixes a real bug on PPC?
- k
next prev parent reply other threads:[~2007-01-30 7:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 5:43 Kumar Gala
2007-01-30 5:55 ` Ananth N Mavinakayanahalli
2007-01-30 7:05 ` Kumar Gala
2007-01-30 7:12 ` Kumar Gala [this message]
2007-01-30 7:41 ` Andrew Morton
2007-01-31 0:04 ` Kumar Gala
2013-07-01 14:33 [PATCH] kprobes: fix " Dong Fang
2013-07-01 14:46 ` Dong Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=112DEBE1-0765-40DC-B8FD-75DE7336312A@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=paulus@samba.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®