mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Allison Henderson <allison.henderson@oracle.com>
To: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"rongqianfeng@vivo.com" <rongqianfeng@vivo.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"horms@kernel.org" <horms@kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH 2/3] RDS: remove redundant __GFP_NOWARN
Date: Tue, 12 Aug 2025 06:54:56 +0000	[thread overview]
Message-ID: <112c31733efe7db786a37cad9113c7292b7c1bdd.camel@oracle.com> (raw)
In-Reply-To: <20250810072944.438574-3-rongqianfeng@vivo.com>

On Sun, 2025-08-10 at 15:29 +0800, Qianfeng Rong wrote:
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
> __GFP_NOWARN.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Looks pretty straight forward to me.  Thanks Qianfeng.

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
>  net/rds/ib_recv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
> index e53b7f266bd7..4248dfa816eb 100644
> --- a/net/rds/ib_recv.c
> +++ b/net/rds/ib_recv.c
> @@ -1034,7 +1034,7 @@ void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic,
>  		rds_ib_stats_inc(s_ib_rx_ring_empty);
>  
>  	if (rds_ib_ring_low(&ic->i_recv_ring)) {
> -		rds_ib_recv_refill(conn, 0, GFP_NOWAIT | __GFP_NOWARN);
> +		rds_ib_recv_refill(conn, 0, GFP_NOWAIT);
>  		rds_ib_stats_inc(s_ib_rx_refill_from_cq);
>  	}
>  }


  reply	other threads:[~2025-08-12  6:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-10  7:29 [PATCH 0/3] net: " Qianfeng Rong
2025-08-10  7:29 ` [PATCH 1/3] tcp: cdg: " Qianfeng Rong
2025-08-11  8:54   ` Eric Dumazet
2025-08-10  7:29 ` [PATCH 2/3] RDS: " Qianfeng Rong
2025-08-12  6:54   ` Allison Henderson [this message]
2025-08-10  7:29 ` [PATCH 3/3] SUNRPC: Remove " Qianfeng Rong
2025-08-10 15:34   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=112c31733efe7db786a37cad9113c7292b7c1bdd.camel@oracle.com \
    --to=allison.henderson@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rds-devel@oss.oracle.com \
    --cc=rongqianfeng@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®