From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5F7C3AB262 for ; Thu, 7 May 2026 13:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159240; cv=none; b=RZ52VbqIhF7IVz9YsBjA3YjZlAb4N87YVp9UF6m/BC29OuSR0243u8yoSk3Xd3lpTm5nQ0w4myjRIL2BqFQfJc5/KgW0IJbGgE9bfhCjIrkQ30gLjsMT7eh5QE8pGRZhOSC/k5jZ/aalVY7fiGHKH5IivYZDdRpZcfkHBFAenKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159240; c=relaxed/simple; bh=ZUyiKciw6bl4ENj0XCgLW65D5u6UhS7JLeemG9SWGzQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AM42M9vcnOx7MTGBIveFTaYN+BHwbxyZg5Q8qNnBaWZTtK1fQjqC8oA9xpfsEpDBR/Wqy+0kzkjY05PI1widRUW1yjfTWxnxVdcDB9V5OVlTToVJbxKvKTuCh2mq3gIt3VYAgEvEDyjlis0gJ/Uav14uge8Jps3aH+yov6rOEYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ry9dN/na; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SDw3TazE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ry9dN/na"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SDw3TazE" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647A3MOg1669566 for ; Thu, 7 May 2026 13:07:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= alNndE+DEmvOgK3PpbgZinouRSm3ht7GhqLFHIt1Qa0=; b=Ry9dN/naFMHXo24r R7poMpUOPzo4QPl8Oah7JhVdAawfqKPfw/eU56VIE9Hg0yUFUjMA9nXzeRCNxkzJ t63iNRElR3MN8Xn8V1QIbRyBJD91hrK9tsFx0fajwDSZFWEFvWc88jz4yAJuJVya bfRKu73reuoZblHdNZp+R6f4b/UgyGrPB2u8CRivKTDxuZilWlf5OIGTqdQ0FhTB CSqVKdSV4SU/ArOTuFrCiaOWfRhtE7MaoIpvDCZZR+4uU51AV0VvxAev73YMCSFe 5ftQAp4rC6hrFnFa6EltRyHM1xGYrh62ylxsGrIymH2LuY9ybn4UURIczlrDNR6Z KRee/A== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0k1p1y0r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 13:07:19 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3662990c03fso225257a91.0 for ; Thu, 07 May 2026 06:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778159238; x=1778764038; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=alNndE+DEmvOgK3PpbgZinouRSm3ht7GhqLFHIt1Qa0=; b=SDw3TazEd1DVyPh72fWEhaOu7UuatlFKZ+rbrQUbyEZiDiZsLENWiZR8kgzbM3BTnq ZJw8pVXdFesyrbsEpRdL6FNSYk9BeeaA3KZtafcLia+aWrWDZKALIMoBDTQpzD39JMm0 zvik1I+PJMjImp7+7z7RoS4SNY3Wdrn+zujsMD+610R/j11PqNz7QsdYQ4OEjtgL4m4B hN/BSrrgJ4lMq3uMYaJGgNkAxwpTnxXTMXcmpl61Oh3Bp2L3b2mhyTdjgvHq/WF9w5jC utL8SWUPSMyHHDJ0vBUOLWvaVYatTr03cGqOENv+xCf+0RFGfJzOSPELlaktX2JXo3L0 GEBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159238; x=1778764038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=alNndE+DEmvOgK3PpbgZinouRSm3ht7GhqLFHIt1Qa0=; b=Tyhs0E4IN7WtfavstvBl54k68Oy6LGkFwpqTQwJZLZorUjiUwpjWqegNzf+yUn5ItM XspE8bd1xvO220FfszHnq/IN0dc8+0w6eth6xIvXjV2Ks5IhrUmEp6eWS1MxyNJFiIkG vuIrEspS9QrqEqzchieQlJ9yb/icbxr+dpVEjx6uRCwGOEo/pnNJkgTRvmNLD6x8o7Ai gRlkUBEUSVKZhT4ctWPfUzXTrRGd3K+8g2WW824vPhHDRHIPwDfSjpqO08a5i+n+djnC kXG63wxmxBAiYMaoyULDiSnroVJ40BP6SjnNbSbOYGtYgjhnA66jzylxkBJ4v8x1N9Pf 0U+A== X-Forwarded-Encrypted: i=1; AFNElJ8b7fCajcMqlBqkp1nc6FU9OSyi+Xr+fpgcJM46rTZxAU1KdWSRk04Zg9WLgE99WWapV+U/xpefDrPm6nE=@vger.kernel.org X-Gm-Message-State: AOJu0YxV89fcZDAMhnH+l9NkSz6OkMAYjx5DeDBIgMlAB0d2IxfIAlo+ fEXNExrNM3P+GLk4ZmNt0DaXgzmXroaLAyMM7FxtgI7UjHAM/mVaAw4AQV1fx47ZtTRPdFs9i3+ hueYfyRGiL743E2bHl7GJlOh5segE4shGwKGKqtveJfmHFNoE3kGv1FBXkyfo1wmOcHk= X-Gm-Gg: AeBDiesRR1jP0HvGQxF0lgBHUvRvYWE7hLWxnWo4WEAlhCw9lr86dPDpxo5OklW0Q6m 2UG+qGoD5TxLKWR+y/tnE7M5urCEVxL5pNAzR/yJ70OvZkb0W0KNZc9wbO8HyTTfFjiEJtmeLk8 zKQn705hiqwt1N7G9umm1mT9HVJYvZithW111lLtTwIVVmW/o0lQVljdhHxBkY6dFLgFAxkbnq+ bSq3tni3UfQUNUsVatFCz9EWc+EPaukvTInf3mVnEr6LD7z9OAvML+b3AyV5l0IznlZznC3V0tH InaPzLAr5XsewbRc+2VrAf4vI3CVCVDHkTGUK8Flyy8saUjA+UBvqS3lQQBnjDZw7ZJpf3+gst8 15LHug63UCP1H3d9gEhrMbnO0ZXtWPr86uakFpPLQFgvXXxSswex+4ycrSFZI+GoCnWbzhsVMLO lFsQ== X-Received: by 2002:a17:90b:582c:b0:35f:c6bf:2bba with SMTP id 98e67ed59e1d1-366055e33afmr2306793a91.11.1778159238383; Thu, 07 May 2026 06:07:18 -0700 (PDT) X-Received: by 2002:a17:90b:582c:b0:35f:c6bf:2bba with SMTP id 98e67ed59e1d1-366055e33afmr2306747a91.11.1778159237855; Thu, 07 May 2026 06:07:17 -0700 (PDT) Received: from [192.168.0.172] ([49.205.248.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-365f01a4f51sm1816381a91.4.2026.05.07.06.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 06:07:17 -0700 (PDT) Message-ID: <112f80a6-40b9-442b-8aa2-a374fedd978c@oss.qualcomm.com> Date: Thu, 7 May 2026 18:37:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/16] media: iris: Introduce set_preset_register as a vpu_op To: Dmitry Baryshkov , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal References: <20260507-iris-ar50lt-v1-0-d22cccedc3e2@oss.qualcomm.com> <20260507-iris-ar50lt-v1-3-d22cccedc3e2@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260507-iris-ar50lt-v1-3-d22cccedc3e2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDEzMSBTYWx0ZWRfX/s88weGiqQwy yi+eLVFic9XfGFy+OqZ81kqLT848CM4JHYqcZoe+PJ7dymLDQL+snMazPEeYvrqQpIxEay5pb9c fQMOyqHRz74QiIswNgkGyQGg332E/zbSupltLqiGn94WWqkya/6eaLhsQaerjmizhEeCa/T7N8P 4zJmcwW/fOTQhMT3hInqkNDSW52VHKu1t/Hp6cG1SdlYny1oWx9pmnU3WYskw16AriU3RqIrBYg KuxiOWYbljn+iHuN74VOULm+LFbnr4YDF9YGH1umzPQeIOhzMKNJcFf0rDq/FyeeetL7l/sSUGv c3UQpejHAWELWdiVph46ChuxkmTa96vOcSMhEn3GEfCVYF2MAje/VZIyaeZxnRhsLrnALEJDwQc RwZxk32qZ5UdPt8+PSJIgxHBHj5iRuwrKvO7Qn0JooPHckmNAnj1K2hryTjYYDrse8QJWw/+cK/ PvQIBd8g9JZWz/wqN9Q== X-Proofpoint-GUID: JPYkpxLZWg5kWAj1JNPTMOkDBasIfNWq X-Proofpoint-ORIG-GUID: JPYkpxLZWg5kWAj1JNPTMOkDBasIfNWq X-Authority-Analysis: v=2.4 cv=K4IS2SWI c=1 sm=1 tr=0 ts=69fc8e87 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=EkRsrf7Hk27R9rd+nIzaeA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=-LUH1mPZw7eumpYd8pAA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070131 On 5/7/2026 12:12 PM, Dmitry Baryshkov wrote: > From: Dikshita Agarwal > > The set_preset_registers sequence is currently shared across all > supported devices. Starting with Qualcomm QCM2290 (AR50LT), the register > programming would differ. > > Move set_preset_register into a vpu_op to allow per-device > customization. > > This change prepares the driver for upcoming hardware variants. > No functional change so far for existing devices. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Dikshita Agarwal > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_vpu2.c | 1 + > drivers/media/platform/qcom/iris/iris_vpu3x.c | 3 +++ > drivers/media/platform/qcom/iris/iris_vpu4x.c | 1 + > drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +- > drivers/media/platform/qcom/iris/iris_vpu_common.h | 1 + > 5 files changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Vikash Garodia