From: Anton Altaparmakov <aia21@cam.ac.uk>
To: Hugh Dickins <hugh@veritas.com>
Cc: David Howells <dhowells@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: what happened to page_mkwrite? - was: Re: page_mkwrite seems broken
Date: Mon, 24 Oct 2005 16:16:45 +0100 [thread overview]
Message-ID: <1130167005.19518.35.camel@imp.csi.cam.ac.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0502091357001.6086@goblin.wat.veritas.com>
Hi,
On Wed, 2005-02-09 at 14:28 +0000, Hugh Dickins wrote:
> On Fri, 4 Feb 2005, Hugh Dickins wrote in another thread:
> > Isn't this exactly what David Howells' page_mkwrite stuff in -mm's
> > add-page-becoming-writable-notification.patch is designed for?
> >
> > Though it looks a little broken to me as it stands (beyond the two
> > fixup patches already there). I've not found time to double-check
> > or test, apologies in advance if I'm libelling, but...
> >
> > (a) I thought the prot bits do_nopage gives a pte in a shared writable
> > mapping include write permission, even when it's a read fault:
> > that can't be allowed if there's a page_mkwrite.
> >
> > (b) I don't understand how do_wp_page's "reuse" logic for whether it
> > can just go ahead and use the existing anonymous page, would have
> > any relevance to calling page_mkwrite on a shared writable page,
> > which must be used and not COWed however many references there are.
>
> I have now looked further, and both points still seem valid to me:
> the page_mkwrite calling code looks doubly broken. (Tested?)
>
> Nor has there been any movement on the points raised by Christoph,
> that aops->page_mkwrite is redundant, and do_wp_page_mk_pte_writable
> separation unhelpful.
>
> I could probably put page_mkwrite to use in tmpfs (to eliminate its
> unsatisfactory but never over-troubling shmem_recalc_inode), but not
> as it currently stands.
>
> Are you planning any movement on this, David?
> Or should I have a go sometime?
What happened with page_mkwrite? It seems to have disappeared both from
-mm and generally from the face of the earth...
I am very interested in having such ability for ntfs...
Is anyone still working on this? If not why not? Did it prove
impractical or ...?
If no-one is working on this anymore, where do I find the last "current"
patch?
Thanks a lot in advance!
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
next prev parent reply other threads:[~2005-10-24 15:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-09 14:28 Hugh Dickins
2005-10-24 15:16 ` Anton Altaparmakov [this message]
2005-10-24 15:36 ` what happened to page_mkwrite? - was: " Hugh Dickins
2005-10-24 15:49 ` Anton Altaparmakov
2005-10-24 15:26 ` David Howells
2005-10-24 15:43 ` Anton Altaparmakov
2005-10-24 16:01 ` Hugh Dickins
2005-10-24 19:38 ` Anton Altaparmakov
2005-10-24 20:31 ` Hugh Dickins
2005-10-24 21:18 ` Anton Altaparmakov
2005-10-24 16:23 ` [PATCH] Add notification of page becoming writable to VMA ops David Howells
2005-10-24 19:11 ` Hugh Dickins
2005-10-25 7:59 ` Anton Altaparmakov
2005-10-25 8:26 ` Hugh Dickins
2005-10-25 8:49 ` Anton Altaparmakov
2005-10-25 9:49 ` David Howells
2005-10-25 9:55 ` David Howells
2005-10-25 10:12 ` David Howells
2005-10-25 13:18 ` [PATCH] Add notification of page becoming writable to VMA ops [try #2] David Howells
2005-11-30 13:58 ` [PATCH] Add notification of page becoming writable to VMA ops [try #3] David Howells
2005-11-30 14:40 ` Miklos Szeredi
2005-11-30 14:50 ` David Howells
2005-11-30 15:20 ` [PATCH] Add notification of page becoming writable to VMA ops [try #4] David Howells
2006-01-11 12:19 ` [PATCH] Add notification of page becoming writable to VMA ops [try #5] David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130167005.19518.35.camel@imp.csi.cam.ac.uk \
--to=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®