From: Richard Purdie <rpurdie@rpsys.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: sharp zaurus c-3000: fix compile failure without CONFIG_FB_PXA
Date: Mon, 24 Oct 2005 19:16:01 +0100 [thread overview]
Message-ID: <1130177761.8345.144.camel@localhost.localdomain> (raw)
In-Reply-To: <20051024172639.GA30960@elf.ucw.cz>
On Mon, 2005-10-24 at 19:26 +0200, Pavel Machek wrote:
> This fixes compile problem when CONFIG_FB_PXA is not set.
>
> LD .tmp_vmlinux1
> arch/arm/mach-pxa/built-in.o(.text+0x1d74): In function
> `spitz_get_hsync_len':
> : undefined reference to `pxafb_get_hsync_time'
> make: *** [.tmp_vmlinux1] Error 1
> 3.46user 0.46system 5.10 (0m5.106s) elapsed 77.01%CPU
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
>
> diff --git a/arch/arm/mach-pxa/corgi_lcd.c b/arch/arm/mach-pxa/corgi_lcd.c
> --- a/arch/arm/mach-pxa/corgi_lcd.c
> +++ b/arch/arm/mach-pxa/corgi_lcd.c
> @@ -488,6 +488,7 @@ static int is_pxafb_device(struct device
>
> unsigned long spitz_get_hsync_len(void)
> {
> +#ifdef CONFIG_FB_PXA
> if (!spitz_pxafb_dev) {
> spitz_pxafb_dev = bus_find_device(&platform_bus_type, NULL, NULL, is_pxafb_device);
> if (!spitz_pxafb_dev)
> @@ -496,6 +497,7 @@ unsigned long spitz_get_hsync_len(void)
> if (!get_hsync_time)
> get_hsync_time = symbol_get(pxafb_get_hsync_time);
> if (!get_hsync_time)
> +#endif
> return 0;
>
> return pxafb_get_hsync_time(spitz_pxafb_dev);
>
>
prev parent reply other threads:[~2005-10-24 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 17:26 Pavel Machek
2005-10-24 18:16 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130177761.8345.144.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®