From: "Madhu K.S." <madhu.subbaiah@wipro.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Subject: Re: select() for delay.
Date: Tue, 25 Oct 2005 11:56:41 +0530 [thread overview]
Message-ID: <1130221601.7416.6.camel@penguin.madhu> (raw)
In-Reply-To: <1130160451.2775.8.camel@laptopd505.fenrus.org>
Hi All,
Someone please comment on the entire patch functionality.
I tested this patch, it seems to work fine.
Kindly suggest.
On Mon, 2005-10-24 at 18:57, Arjan van de Ven wrote:
> On Mon, 2005-10-24 at 09:18 -0400, Steven Rostedt wrote:
> > Hi Maduhu,
> >
> > On Mon, 2005-10-24 at 16:25 +0530, madhu.subbaiah@wipro.com wrote:
> >
> > > + put_user(sec, &tvp->tv_sec);
> > > + put_user(usec, &tvp->tv_usec);
> >
> > I won't comment on the rest of the patch, but this part is definitely
> > wrong. The pointer tvp is a user space address and once you dereference
> > that pointer to get to tv_sec, you can have a fault, which might
> > segfault the
>
> &pointer->member doesn't dereference the pointer, it just adds the
> offset of "member" to the content of the pointer.
>
>
next prev parent reply other threads:[~2005-10-25 6:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 10:55 madhu.subbaiah
2005-10-24 13:18 ` Steven Rostedt
2005-10-24 13:27 ` Arjan van de Ven
2005-10-24 13:37 ` Steven Rostedt
2005-10-25 6:26 ` Madhu K.S. [this message]
2005-10-30 19:06 ` Arnd Bergmann
2005-10-30 19:12 ` Arjan van de Ven
2005-10-31 15:46 ` Christopher Friesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130221601.7416.6.camel@penguin.madhu \
--to=madhu.subbaiah@wipro.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®