From: Rusty Russell <rusty@rustcorp.com.au>
To: Paul Jackson <pj@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched hardcode non-smp set_cpus_allowed
Date: Sat, 29 Oct 2005 11:33:37 +1000 [thread overview]
Message-ID: <1130549617.7615.50.camel@localhost.localdomain> (raw)
In-Reply-To: <20051027085346.27658.76262.sendpatchset@sam.engr.sgi.com>
On Thu, 2005-10-27 at 01:53 -0700, Paul Jackson wrote:
> @@ -945,7 +945,7 @@ extern int set_cpus_allowed(task_t *p, c
> #else
> static inline int set_cpus_allowed(task_t *p, cpumask_t new_mask)
> {
> - if (!cpus_intersects(new_mask, cpu_online_map))
> + if (!cpu_isset(0, new_mask))
> return -EINVAL;
> return 0;
> }
Hmm, I do slightly prefer the former, since it is exactly the same as
the SMP case, and doesn't hardcode 0. Perhaps worth making
cpu_online_map a literal "1" for the UP case, which will help
everywhere. With our include web, however, that might be tricky.
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
next prev parent reply other threads:[~2005-10-29 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-27 8:53 Paul Jackson
2005-10-29 1:33 ` Rusty Russell [this message]
2005-10-29 4:25 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130549617.7615.50.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome