From: "Ronald S. Bultje" <rbultje@ronald.bitfreak.net>
To: akpm@osdl.org
Cc: casteyde.christian@free.fr,
mjpeg-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH / 2.6.14] prevent dmesg warning in zr36067 driver
Date: Sat, 29 Oct 2005 20:42:03 -0400 [thread overview]
Message-ID: <1130632924.2690.8.camel@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
Hi,
attached patch fixes the warning "Debug: sleeping function called from
invalid context at include/asm/semaphore.h:102" that the zr36067 driver
emits every time an application using JPEG capture starts up (e.g.
mjpegtools' lavrec). The warning is harmless, but clogs up the dmesg
output. This was logged as bugzilla #5403. (Thanks to Christian Casteyde
for helping me in fixing this long-standing annoyance.)
Signed-off-by: Ronald S. Bultje <rbultje@ronald.bitfreak.net>
Cheers,
Ronald
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 594 bytes --]
--- linux-2.6.14/drivers/media/video/zoran_driver.c.old 2005-10-29 20:36:24.000000000 -0400
+++ linux-2.6.14/drivers/media/video/zoran_driver.c 2005-10-29 20:36:48.000000000 -0400
@@ -996,8 +996,6 @@
return -EINVAL;
}
- spin_lock_irqsave(&zr->spinlock, flags);
-
if (fh->jpg_buffers.active == ZORAN_FREE) {
if (zr->jpg_buffers.active == ZORAN_FREE) {
zr->jpg_buffers = fh->jpg_buffers;
@@ -1016,6 +1014,8 @@
zr36057_enable_jpg(zr, mode);
}
+ spin_lock_irqsave(&zr->spinlock, flags);
+
if (!res) {
switch (zr->jpg_buffers.buffer[num].state) {
case BUZ_STATE_DONE:
reply other threads:[~2005-10-30 0:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130632924.2690.8.camel@localhost.localdomain \
--to=rbultje@ronald.bitfreak.net \
--cc=akpm@osdl.org \
--cc=casteyde.christian@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mjpeg-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®