From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dave Jones <davej@redhat.com>
Cc: Keith Owens <kaos@ocs.com.au>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.14 assorted warnings
Date: Sun, 30 Oct 2005 22:15:31 +0000 [thread overview]
Message-ID: <1130710531.32734.5.camel@localhost.localdomain> (raw)
In-Reply-To: <20051028073049.GA27389@redhat.com>
On Gwe, 2005-10-28 at 03:30 -0400, Dave Jones wrote:
> gcc is dumb, it doesn't realise that the variable will be filled by another
> function if its passed thus..
>
> unsigned long foo
> bar(&foo)
> if (foo==1)
> ...
>
> With bar() filling in content of foo.
> I believe there's at least once instance of this in gcc bugzilla.
gcc is a *LOT* smarter than you give it credit for. It will not warn for
cases where it isn't able to tell how foo is used passed with &foo. It
will warn for cases where it can
Compile the following program with and without -O2 and you'll see just
how smart gcc actually is
#include <stdio.h>
static void bar(char *x) {
*x = 1;
}
static void baz(char *x) {
printf("Wombat\n");
}
int main(int argc, char *argv[]) {
char x,y;
bar(&x);
baz(&y);
printf("%c,%c\n", x, y);
}
So I'd go look deeper for real bugs
Alan
next prev parent reply other threads:[~2005-10-30 21:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-28 7:21 Keith Owens
2005-10-28 7:28 ` Jens Axboe
2005-10-28 7:30 ` Dave Jones
2005-10-28 8:07 ` Arnd Bergmann
2005-10-28 8:29 ` Jens Axboe
2005-10-29 5:59 ` Richard Knutsson
2005-10-29 6:03 ` Al Viro
2005-10-28 8:10 ` Richard Knutsson
2005-10-30 22:15 ` Alan Cox [this message]
2005-10-30 22:25 ` Al Viro
2005-10-30 22:32 ` Al Viro
2005-10-30 22:29 ` Stephen Rothwell
2005-10-31 0:53 ` Paul Mackerras
2005-10-31 0:57 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130710531.32734.5.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome