From: Trond Myklebust <trondmy@trondhjem.org>
To: NeilBrown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH against 2.6.14] truncate() or ftruncate shouldn't change mtime if size doesn't change.
Date: Mon, 31 Oct 2005 08:37:38 -0500 [thread overview]
Message-ID: <1130765858.8802.36.camel@lade.trondhjem.org> (raw)
In-Reply-To: <1130763105.8802.23.camel@lade.trondhjem.org>
On Mon, 2005-10-31 at 07:51 -0500, Trond Myklebust wrote:
> This should normally be OK as far as NFS is concerned since we usually
> end up revalidating the attribute cache in the lookup() code, but you
> could imagine a networked filesystem that does not do this. I'd
> therefore prefer if such checks were made in the filesystem itself.
Actually, I'm wrong about this. ftruncate() doesn't do a
lookup/lookup_revalidate, so the current NFS code may end up using stale
attribute data.
Moving the checks to the VFS will just make that problem unfixable,
though.
Cheers,
Trond
next prev parent reply other threads:[~2005-10-31 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20051031173358.9566.patches@notabene>
2005-10-31 6:34 ` NeilBrown
2005-10-31 7:48 ` Andrew Morton
2005-10-31 9:48 ` Anton Altaparmakov
2005-10-31 10:16 ` Anton Altaparmakov
2005-10-31 10:41 ` Neil Brown
2005-10-31 10:30 ` Neil Brown
2005-10-31 10:42 ` Anton Altaparmakov
2005-10-31 12:51 ` Trond Myklebust
2005-10-31 13:37 ` Trond Myklebust [this message]
2005-10-31 22:53 ` Neil Brown
2005-11-01 0:40 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130765858.8802.36.camel@lade.trondhjem.org \
--to=trondmy@trondhjem.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®