PROBLEM: potential null-pointer dereference in fs/bfs/inode.c

[Nic Volanschi <nic.volanschi@free.fr>]

Hi Tigran,

While looking into the BFS code of kernel 2.6.13, I noticed what seems
to be a potential null-pointer dereference bug in file fs/bfs/inode.c,
function bfs_fill_super(), within the following piece of code:

		inode = iget(s,i);
		if (BFS_I(inode)->i_dsk_ino == 0)
			info->si_freei++;

Is it correct that iget() may return a Null value, and in that case, we
have a null-pointer exception on the subsequent line?

Please let me know if you confirm or not this diagnostics.
Best regards,
Nic.


[1.] One line summary of the problem:    
 potential null-pointer dereference in fs/bfs/inode.c
[2.] Full description of the problem/report:
  see above
[3.] Keywords (i.e., modules, networking, kernel): 
 BFS file system
[4.] Kernel version (from /proc/version): 2.6.13
[5.] Most recent kernel version which did not have the bug:
[6.] Output of Oops.. message (if applicable) with symbolic information
     resolved (see Documentation/oops-tracing.txt)
[7.] A small shell script or example program which triggers the
     problem (if possible)
[8.] Environment
[8.1.] Software (add the output of the ver_linux script here)
[8.2.] Processor information (from /proc/cpuinfo): AMD athlon XP 2800+
[8.3.] Module information (from /proc/modules):
[8.4.] Loaded driver and hardware information (/proc/ioports,
/proc/iomem)
[8.5.] PCI information ('lspci -vvv' as root)
[8.6.] SCSI information (from /proc/scsi/scsi)
[8.7.] Other information that might be relevant to the problem
       (please look in /proc and include all information that you
       think to be relevant):
[X.] Other notes, patches, fixes, workarounds: