From: Roland Dreier <rolandd@cisco.com>
To: linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: [git patch review 6/6] [IB] mthca: fix typo in catastrophic error polling
Date: Tue, 08 Nov 2005 06:30:19 +0000 [thread overview]
Message-ID: <1131431419061-a91722e21245ff50@cisco.com> (raw)
In-Reply-To: <1131431419061-26662c4d4f27ac0a@cisco.com>
Fix a typo in the rearming of the catastrophic error polling timer: we
should rearm the timer as long as the stop flag is _not_ set.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
drivers/infiniband/hw/mthca/mthca_catas.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
applies-to: 35085d3edccfc4f18930f45c4a1c896d041e7856
b523cfbb7bab356f66525e518f5b8c25cf0357d7
diff --git a/drivers/infiniband/hw/mthca/mthca_catas.c b/drivers/infiniband/hw/mthca/mthca_catas.c
index 7ac52af..3447cd7 100644
--- a/drivers/infiniband/hw/mthca/mthca_catas.c
+++ b/drivers/infiniband/hw/mthca/mthca_catas.c
@@ -94,7 +94,7 @@ static void poll_catas(unsigned long dev
}
spin_lock_irqsave(&catas_lock, flags);
- if (dev->catas_err.stop)
+ if (!dev->catas_err.stop)
mod_timer(&dev->catas_err.timer,
jiffies + MTHCA_CATAS_POLL_INTERVAL);
spin_unlock_irqrestore(&catas_lock, flags);
---
0.99.9e
prev parent reply other threads:[~2005-11-08 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 6:30 [git patch review 1/6] [IB] mthca: report page size capability Roland Dreier
2005-11-08 6:30 ` [git patch review 2/6] [IB] umad: two small fixes Roland Dreier
2005-11-08 6:30 ` [git patch review 3/6] [IPoIB] add path record information in debugfs Roland Dreier
2005-11-08 6:30 ` [git patch review 4/6] [IB] umad: avoid potential deadlock when unregistering MAD agents Roland Dreier
2005-11-08 6:30 ` [git patch review 5/6] [IPoIB] no need to set skb->dev right before freeing skb Roland Dreier
2005-11-08 6:30 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131431419061-a91722e21245ff50@cisco.com \
--to=rolandd@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®