From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hch@lst.de
Subject: Re: [PATCH] Remove read-only check from inode_update_time().
Date: Wed, 09 Nov 2005 17:04:11 -0600 [thread overview]
Message-ID: <1131577451.21652.10.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0511092243001.7946@hermes-1.csi.cam.ac.uk>
On Wed, 2005-11-09 at 22:48 +0000, Anton Altaparmakov wrote:
> Hi Andrew,
>
> The read-only check in inode_update_time() (or file_update_time() as it is
> now in -mm) is unnecessary as the VFS better have done all the read-only
> checks and aborted much earlier in the file write code paths where
> inode/file_update_time() is only called from.
I notice inode_update_time is called from pipe_writev. I don't know how
likely it would be in practice, but wouldn't it be possible to write to
a pipe on a read-only partition? In that case the read-only check still
makes sense.
> (In case you were not following the ntfs discussion, Christoph Hellwig
> agreed that check is unnecessary and can be removed.)
>
> Patch against latest Linus git tree is below, please apply. If you prefer
> a patch on top of Christoph's file_update_time() check please let me
> know...
>
> Best regards,
>
> Anton
--
David Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2005-11-09 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 22:48 Anton Altaparmakov
2005-11-09 23:04 ` Dave Kleikamp [this message]
2005-11-09 23:22 ` Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131577451.21652.10.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®