From: Alan Hourihane <alanh@fairlite.demon.co.uk>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>
Subject: Re: [PATCH] AGP performance fixes
Date: Wed, 09 Nov 2005 23:44:08 +0000 [thread overview]
Message-ID: <1131579848.5973.113.camel@jetpack.demon.co.uk> (raw)
In-Reply-To: <1131578955.24637.116.camel@gaston>
On Thu, 2005-11-10 at 10:29 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2005-11-09 at 12:02 -0800, Linux Kernel Mailing List wrote:
> > tree 048db8e12c2b31ec2b88c3154da4c6a77b80028c
> > parent 329f7dba5f7dc3bc9a30ad00cf373d2e83115aa1
> > author Alan Hourihane <alanh@fairlite.demon.co.uk> Mon, 07 Nov 2005 15:35:34 -0800
> > committer Dave Jones <davej@redhat.com> Wed, 09 Nov 2005 05:43:54 -0800
> >
> > [PATCH] AGP performance fixes
> >
> > AGP allocation/deallocation is suffering major performance issues due to
> > the nature of global_flush_tlb() being called on every change_page_attr()
> > call.
>
> .../...
>
> *** Warning: ".global_flush_tlb" [drivers/char/agp/agpgart.ko] undefined!
>
> Am I supposed to define something new for uninorth-agp ? Is this yet another
> x86-only (or worse, some x86 chipsets only concept going global ?
change global_flush_tlb() to flush_agp_mappings() and you should be
fine.
Linus has a fix for this.
Alan.
next prev parent reply other threads:[~2005-11-09 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200511092002.jA9K25J8025643@hera.kernel.org>
2005-11-09 23:29 ` Benjamin Herrenschmidt
2005-11-09 23:44 ` Alan Hourihane [this message]
2005-11-09 23:53 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131579848.5973.113.camel@jetpack.demon.co.uk \
--to=alanh@fairlite.demon.co.uk \
--cc=benh@kernel.crashing.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®