From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B8F82914 for ; Sun, 4 May 2025 07:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746344670; cv=none; b=dZNZfmf1S7I/D5haC39XgGYobJk6BUvOoOE622AM3Kp11o3bjq9ooTvMcrn7yu+aqtJHUOH9NhdRpyaqd/yCfWioCPdis1TcfoqTlU5Jfe1kOENd5So1iWMjEOcIIIZmtQv+d50mnW82qXJEZJCHBVHRdPKCsgo8prwHrNi4JUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746344670; c=relaxed/simple; bh=21mF7GGvhKxCxIsg7RdXbZxoyesIIBXLOxGvhhmiFpA=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=BnGG9IgeiAAeAOAH8VLb00H1YQaumQUKcBTtrEfnSzIkNkYON3ZFal6dY3vVBRQqz6iymzZ1NmqdQFHfbyQvFplLo9JPt90QH2/lLJNmsp9NAQHXANByJdf3DZ0leBVy/MRmD0idw2IWkoJSYzKJqvY/hw/VrBUL2D9q7VPFeho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z8pDscRo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z8pDscRo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746344667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HfF7twt06sZ68owiim+5oeU+EgBX8tp+EfU5oHUZCxQ=; b=Z8pDscRoIpYzbVoFOVifVKk/IoPACajYCNjTNHeQWLrdXZ4D3NFNtBuAdy+KhoBLxBHiBG 6LCGtLgItwK/A+GGBnnwNkqdB5M6KLgNbd+nQlwJ5PEjmQ2VlgaJTnzdkhScL5XXbJPv+J AFPl6ZXbB6IOu03C8CCU0Z2C4vQv86M= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-dx-Gq_aEMMihiCglvzzivA-1; Sun, 04 May 2025 03:44:24 -0400 X-MC-Unique: dx-Gq_aEMMihiCglvzzivA-1 X-Mimecast-MFC-AGG-ID: dx-Gq_aEMMihiCglvzzivA_1746344661 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B4299195608C; Sun, 4 May 2025 07:44:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.188]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E623B1800352; Sun, 4 May 2025 07:44:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20250430152554.23646-1-jarkko@kernel.org> <1121543.1746310761@warthog.procyon.org.uk> To: Herbert Xu Cc: dhowells@redhat.com, Jarkko Sakkinen , keyrings@vger.kernel.org, Lukas Wunner , Ignat Korchagin , "David S. Miller" , Peter Huewe , Jason Gunthorpe , Paul Moore , James Morris , "Serge E. Hallyn" , James Bottomley , Mimi Zohar , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH] KEYS: Invert FINAL_PUT bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1131865.1746344653.1@warthog.procyon.org.uk> Date: Sun, 04 May 2025 08:44:13 +0100 Message-ID: <1131866.1746344653@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Herbert Xu wrote: > + key->flags |= KEY_FLAG_DONT_GC_YET; You need __set_bit() or 1<