mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@kihontech.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [patch -rt] make gendev_rel_sem a compat_semaphore
Date: Wed, 16 Nov 2005 10:31:32 -0500	[thread overview]
Message-ID: <1132155092.6266.6.camel@localhost.localdomain> (raw)

Hi Ingo,

I was getting the following:

BUG: nonzero lock count 10 at exit time?
        modprobe: 2972 [ffff81007e1aaf70, 116]

Call Trace:<ffffffff8014e2db>{printk_task+43} <ffffffff8015040f>{check_no_held_locks+111}
       <ffffffff80136d3c>{do_exit+3036} <ffffffff80136f5c>{do_group_exit+268}
       <ffffffff80136f72>{sys_exit_group+18} <ffffffff8011e471>{ia32_sysret+0}

---------------------------
| preempt count: 00000000 ]
| 0-level deep critical section nesting:
----------------------------------------
hdc: ATAPI 40X DVD-ROM DVD-R CD-R/RW drive, 2048kB Cache, UDMA(33)
Uniform CD-ROM driver Revision: 3.20

BUG: modprobe/2972, lock held at task exit time!
 [ffffffff8809fd00] {(struct semaphore *)(&hwif->gendev_rel_sem)}
.. held by:          modprobe: 2972 [ffff81007e1aaf70, 116]
... acquired at:               init_hwif_data+0xaf/0x1a0 [ide_core]

[snipped to not be so annoying]

Looking into this I see that gendev_rel_sem, which is only used when the
device is unregistered, is defined as a semaphore.  This patch changes
this to be a compat_semaphore.

-- Steve

Index: linux-2.6.14-rt13/include/linux/ide.h
===================================================================
--- linux-2.6.14-rt13.orig/include/linux/ide.h	2005-11-15 11:12:37.000000000 -0500
+++ linux-2.6.14-rt13/include/linux/ide.h	2005-11-16 10:09:10.000000000 -0500
@@ -910,7 +910,7 @@
 	unsigned	sg_mapped  : 1;	/* sg_table and sg_nents are ready */
 
 	struct device	gendev;
-	struct semaphore gendev_rel_sem; /* To deal with device release() */
+	struct compat_semaphore gendev_rel_sem; /* To deal with device release() */
 
 	void		*hwif_data;	/* extra hwif data */
 



             reply	other threads:[~2005-11-16 15:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-16 15:31 Steven Rostedt [this message]
2005-11-16 15:34 ` Steven Rostedt
2005-11-17  8:34   ` Ingo Molnar
2005-11-17 16:08   ` Daniel Walker
2005-11-17 17:49     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1132155092.6266.6.camel@localhost.localdomain \
    --to=rostedt@kihontech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®