From: David Woodhouse <dwmw2@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@osdl.org>,
Matthew Wilcox <matthew@wil.cx>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>,
Ian Molton <spyro@f2s.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 4/5] Centralise NO_IRQ definition
Date: Tue, 22 Nov 2005 11:13:11 +0000 [thread overview]
Message-ID: <1132657991.15117.76.camel@baythorne.infradead.org> (raw)
In-Reply-To: <1132611631.11842.83.camel@localhost.localdomain>
On Mon, 2005-11-21 at 22:20 +0000, Alan Cox wrote:
> > Yes, G5 powermacs have the SATA controller on irq 0. So if we can't
> > use irq 0, I can't get to my hard disk. :) Other powermacs also use
> > irq 0 for various things, as do embedded PPC machines.
>
> G5 powermacs have the SATA controller on physical IRQ value 0. Linux IRQ
> values don't need to exactly map. One of the x86 ports handles 'real IRQ
> 0' exactly this way. Its a cookie. Sure would benefit from a function
> for turning an IRQ into a description as a cleanup.
Remapping in that way sounds like a half-arsed hack to work around the
problem which Matthew is trying to fix properly by using NO_IRQ == -1.
Yes, there are drivers which are currently broken and assume irq 0 is
'no irq'. They are broken. Let's just fix them and not continue the
brain-damage.
--
dwmw2
next prev parent reply other threads:[~2005-11-22 11:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 1:14 Matthew Wilcox
2005-11-21 11:12 ` David Howells
2005-11-21 12:14 ` Matthew Wilcox
2005-11-21 18:55 ` Linus Torvalds
2005-11-21 19:06 ` Matthew Wilcox
2005-11-21 19:27 ` Linus Torvalds
2005-11-21 19:43 ` Matthew Wilcox
2005-11-21 19:59 ` Linus Torvalds
2005-11-21 21:15 ` Ingo Molnar
2005-11-21 21:25 ` Paul Mackerras
2005-11-21 21:35 ` Ingo Molnar
2005-11-21 21:51 ` Linus Torvalds
2005-11-21 22:09 ` Benjamin Herrenschmidt
2005-11-21 22:34 ` Linus Torvalds
2005-11-21 23:00 ` Benjamin Herrenschmidt
2005-11-21 21:49 ` Linus Torvalds
2005-11-21 22:06 ` Benjamin Herrenschmidt
2005-11-21 22:28 ` Linus Torvalds
2005-11-21 22:58 ` Benjamin Herrenschmidt
2005-11-21 23:20 ` Paul Mackerras
2005-11-22 1:26 ` Linus Torvalds
2005-11-22 2:45 ` Matthew Wilcox
2005-11-21 21:50 ` Benjamin Herrenschmidt
2005-11-21 22:20 ` Alan Cox
2005-11-22 11:13 ` David Woodhouse [this message]
2005-11-22 14:15 ` Alan Cox
2005-11-22 14:04 ` Matthew Wilcox
2005-11-22 17:03 ` Linus Torvalds
2005-11-22 18:20 ` Matthew Wilcox
2005-11-22 18:37 ` David Howells
2005-11-22 19:03 ` David Woodhouse
2005-11-22 19:21 ` Linus Torvalds
2005-11-22 23:58 ` David Woodhouse
2005-11-22 19:05 ` Linus Torvalds
2005-11-22 19:38 ` David Howells
2005-11-22 19:51 ` Linus Torvalds
2005-11-23 1:45 ` Pavel Machek
2005-11-21 21:16 ` Benjamin Herrenschmidt
2005-11-21 21:38 ` Linus Torvalds
2005-11-21 21:53 ` Benjamin Herrenschmidt
2005-11-21 22:18 ` Linus Torvalds
2005-11-21 22:20 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1132657991.15117.76.camel@baythorne.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rmk@arm.linux.org.uk \
--cc=spyro@f2s.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®