From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbcF1OEp (ORCPT ); Tue, 28 Jun 2016 10:04:45 -0400 Received: from forward2m.cmail.yandex.net ([5.255.216.20]:33704 "EHLO forward2m.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbcF1OEo (ORCPT ); Tue, 28 Jun 2016 10:04:44 -0400 X-Greylist: delayed 551 seconds by postgrey-1.27 at vger.kernel.org; Tue, 28 Jun 2016 10:04:44 EDT Authentication-Results: mxback4m.mail.yandex.net; dkim=pass header.i=@yandex.ru From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Julia Lawall Cc: Amitoj Kaur Chawla , "linux-kernel@vger.kernel.org" In-Reply-To: References: <20160624061843.GA23431@amitoj-Inspiron-3542> <1848631467118640@web17g.yandex.ru> Subject: Re: [PATCH] w1: Remove unneeded header file MIME-Version: 1.0 Message-Id: <113321467122128@web10m.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 28 Jun 2016 16:55:28 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi 28.06.2016, 16:50, "Julia Lawall" : >>  24.06.2016, 09:18, "Amitoj Kaur Chawla" : >>  > The Coccinelle semantic patch used to make this change is as follows: >>  > @ includesmodule @ >>  > @@ >>  > >>  > #include >>  > >>  > @ depends on includesmodule @ >>  > @@ >>  > >>  > - #include >>  > >>  > Signed-off-by: Amitoj Kaur Chawla >> >>  Looks good to me, but these @@ are pretty cryptic. > > There are two rules. The first checks for an include of module.h. The > second depends on the success of the first one. It removes and include o > moduleparam.h. Ok, I see, it makes much more sense now :) Thank you for clarification