From: Shaohua Li <shaohua.li@intel.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: "Raj, Ashok" <ashok.raj@intel.com>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
akpm <akpm@osdl.org>
Subject: [PATCH] setting irq affinity is broken in ia32 with MSI enabled
Date: Wed, 30 Nov 2005 00:37:15 -0800 [thread overview]
Message-ID: <1133339835.8212.14.camel@linux.site> (raw)
Setting irq affinity stops working when MSI is enabled. With MSI,
move_irq is empty, so we can't change irq affinity. It appears a typo in
Ashok's original commit for this issue. X86_64 actually is using
move_native_irq.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
--- a/arch/i386/kernel/io_apic.c 2005-11-29 22:22:16.000000000 -0800
+++ b/arch/i386/kernel/io_apic.c 2005-11-29 22:23:01.000000000 -0800
@@ -2009,7 +2009,7 @@ static void ack_edge_ioapic_vector(unsig
{
int irq = vector_to_irq(vector);
- move_irq(vector);
+ move_native_irq(vector);
ack_edge_ioapic_irq(irq);
}
@@ -2024,7 +2024,7 @@ static void end_level_ioapic_vector (uns
{
int irq = vector_to_irq(vector);
- move_irq(vector);
+ move_native_irq(vector);
end_level_ioapic_irq(irq);
}
next reply other threads:[~2005-11-30 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-30 8:37 Shaohua Li [this message]
2005-11-30 2:31 ` Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133339835.8212.14.camel@linux.site \
--to=shaohua.li@intel.com \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®