From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751234AbVK3Ord (ORCPT ); Wed, 30 Nov 2005 09:47:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751252AbVK3Ord (ORCPT ); Wed, 30 Nov 2005 09:47:33 -0500 Received: from pat.uio.no ([129.240.130.16]:36529 "EHLO pat.uio.no") by vger.kernel.org with ESMTP id S1751234AbVK3Orc (ORCPT ); Wed, 30 Nov 2005 09:47:32 -0500 Subject: Re: NFS cache consistancy appears to be broken... From: Trond Myklebust To: Steve Dickson Cc: Linux NFS Mailing List , linux-kernel In-Reply-To: <438DB65D.8010306@RedHat.com> References: <200510281607.j9SG7Tll024133@hera.kernel.org> <438D0E80.2020905@RedHat.com> <1133334608.8010.9.camel@lade.trondhjem.org> <438DB65D.8010306@RedHat.com> Content-Type: text/plain Date: Wed, 30 Nov 2005 09:47:14 -0500 Message-Id: <1133362034.8625.12.camel@lade.trondhjem.org> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 Content-Transfer-Encoding: 7bit X-UiO-Spam-info: not spam, SpamAssassin (score=-2.938, required 12, autolearn=disabled, AWL 1.88, FORGED_RCVD_HELO 0.05, RCVD_IN_SORBS_DUL 0.14, UIO_MAIL_IS_INTERNAL -5.00) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2005-11-30 at 09:25 -0500, Steve Dickson wrote: > It was the simple fact that nfsi->cache_change_attribute was not being > initialized to jiffies when the nfs inode was being allocated. This > meant when nfs_revalidate_mapping() was called with the > NFS_INO_INVALID_DATA bit was on, nfsi->cache_change_attribute > was not being changed, it was actually being set! That makes sense. Thanks! Cheers, Trond