mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John McCutchan <ttb@tentacle.dhs.org>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: Robert Love <rml@novell.com>, Andrew Morton <akpm@osdl.org>
Subject: [patch] add two inotify_add_watch flags
Date: Tue, 06 Dec 2005 22:54:48 -0500	[thread overview]
Message-ID: <1133927688.20396.8.camel@localhost.localdomain> (raw)

Yo,

The below patch lets user space have more control over the inodes that
inotify will watch. It introduces two new flags. 

	IN_ONLYDIR -- only watch the inode if it is a directory
	This is needed to avoid the race that can occur when we want to be sure
that we are watching a directory.

	IN_DONT_FOLLOW -- don't follow a symlink. In combination with
IN_ONLYDIR we can make sure that we don't watch the target of symlinks.

The issues the flags fix came up when writing the gnome-vfs inotify
backend. Default behaviour is unchanged.


Signed-off-by: John McCutchan <ttb@tentacle.dhs.org>
Index: linux-2.6.14-rc5/fs/inotify.c
===================================================================
--- linux-2.6.14-rc5.orig/fs/inotify.c	2005-10-20 02:23:05.000000000 -0400
+++ linux-2.6.14-rc5/fs/inotify.c	2005-12-06 19:01:22.000000000 -0500
@@ -363,11 +363,18 @@
 /*
  * find_inode - resolve a user-given path to a specific inode and return a nd
  */
-static int find_inode(const char __user *dirname, struct nameidata *nd)
+static int find_inode(const char __user *dirname, struct nameidata *nd,
+		      int only_dir, int dont_follow_symlink)
 {
 	int error;
+	unsigned flags = 0;
 
-	error = __user_walk(dirname, LOOKUP_FOLLOW, nd);
+	if (!dont_follow_symlink)
+		flags |= LOOKUP_FOLLOW;
+	if (only_dir)
+		flags |= LOOKUP_DIRECTORY;
+
+	error = __user_walk(dirname, flags, nd);
 	if (error)
 		return error;
 	/* you can only watch an inode if you have read permissions on it */
@@ -943,7 +950,7 @@
 		goto fput_and_out;
 	}
 
-	ret = find_inode(path, &nd);
+	ret = find_inode(path, &nd, mask & IN_ONLYDIR, mask & IN_DONT_FOLLOW);
 	if (unlikely(ret))
 		goto fput_and_out;
 
Index: linux-2.6.14-rc5/include/linux/inotify.h
===================================================================
--- linux-2.6.14-rc5.orig/include/linux/inotify.h	2005-10-20 02:23:05.000000000 -0400
+++ linux-2.6.14-rc5/include/linux/inotify.h	2005-12-06 18:57:11.000000000 -0500
@@ -47,6 +47,8 @@
 #define IN_MOVE			(IN_MOVED_FROM | IN_MOVED_TO) /* moves */
 
 /* special flags */
+#define IN_ONLYDIR		0x01000000	/* only watch the path if it is a directory */
+#define IN_DONT_FOLLOW		0x02000000	/* don't follow a sym link */
 #define IN_MASK_ADD		0x20000000	/* add to the mask of an already existing watch */
 #define IN_ISDIR		0x40000000	/* event occurred against dir */
 #define IN_ONESHOT		0x80000000	/* only send event once */


             reply	other threads:[~2005-12-07  4:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-07  3:54 John McCutchan [this message]
2005-12-07 18:26 ` Robert Love
2005-12-09 22:51 ` Andrew Morton
2005-12-09 23:07   ` John McCutchan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1133927688.20396.8.camel@localhost.localdomain \
    --to=ttb@tentacle.dhs.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rml@novell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®