From: <Codrin.Ciubotariu@microchip.com>
To: <andrew@lunn.ch>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<Woojung.Huh@microchip.com>, <UNGLinuxDriver@microchip.com>,
<vivien.didelot@gmail.com>, <f.fainelli@gmail.com>,
<davem@davemloft.net>, <kuba@kernel.org>
Subject: Re: [PATCH net] net: dsa: microchip: set the correct number of ports
Date: Thu, 2 Jul 2020 15:16:01 +0000 [thread overview]
Message-ID: <1133ac51-bdda-1005-8afd-75dd1d53cea8@microchip.com> (raw)
In-Reply-To: <20200702135016.GL730739@lunn.ch>
On 02.07.2020 16:50, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Thu, Jul 02, 2020 at 12:44:50PM +0300, Codrin Ciubotariu wrote:
>> The number of ports is incorrectly set to the maximum available for a DSA
>> switch. Even if the extra ports are not used, this causes some functions
>> to be called later, like port_disable() and port_stp_state_set(). If the
>> driver doesn't check the port index, it will end up modifying unknown
>> registers.
>>
>> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Thanks for the minimum patch.
>
> If you wait about a week, net will get merged into net-next. You can
> then submit a refactoring patch based on your previous version.
>
> Andrew
>
Sure thing. This small version does the job, so I will see about the
refactoring, maybe I will group it with something else...
Thank you for your review!
Best regards,
Codrin
next prev parent reply other threads:[~2020-07-02 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 9:44 Codrin Ciubotariu
2020-07-02 13:50 ` Andrew Lunn
2020-07-02 15:16 ` Codrin.Ciubotariu [this message]
2020-07-02 21:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133ac51-bdda-1005-8afd-75dd1d53cea8@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®