From: Jeremy Katz <katzj@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: Pete Zaitcev <zaitcev@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: "block" symlink in sysfs for a multifunction device
Date: Wed, 14 Dec 2005 23:47:35 -0500 [thread overview]
Message-ID: <1134622055.2864.21.camel@bree.local.net> (raw)
In-Reply-To: <20051214234255.GA3275@kroah.com>
On Wed, 2005-12-14 at 15:42 -0800, Greg KH wrote:
> On Wed, Dec 14, 2005 at 03:26:15PM -0800, Pete Zaitcev wrote:
> > On Tue, 13 Dec 2005 21:50:19 -0800, Greg KH <greg@kroah.com> wrote:
> > > $ ls -l /sys/block/uba/device/
> > > -r--r--r-- 1 root root 4096 Dec 13 21:31 bNumEndpoints
> > > lrwxrwxrwx 1 root root 0 Dec 13 21:31 block:uba -> ../../../../../../block/uba
> > > lrwxrwxrwx 1 root root 0 Dec 13 21:31 block:ubb -> ../../../../../../block/ubb
> > > lrwxrwxrwx 1 root root 0 Dec 13 21:31 block:ubc -> ../../../../../../block/ubc
> > > lrwxrwxrwx 1 root root 0 Dec 13 21:31 block:ubd -> ../../../../../../block/ubd
> >
> > Greg, Jeremy is not happy about this.
> >
> > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175563
> > > ------- Additional Comments From katzj@redhat.com 2005-12-14 18:05 EST -------
> > > Actually, this is problematic. It makes it so that the single device directory
> > > corresponds to more than one device which we can't handle with kudzu :-(
>
> Well, how do you handle it for class devices then?
We don't have any where we need to handle it at present.
> And if this isn't acceptable, what would be?
By going this route, it really feels like you're hacking around your own
rule of a single value per file :-) Except that instead of having a
file that I read five values from, it's five files with naming
heuristics to get five values. Which is, in a lot of ways, worse.
I'd much rather see the fact that there are multiple devices be handled
by having each device with its own unique directory. This then keeps
all of the abstractions which currently exist.
Jeremy
next prev parent reply other threads:[~2005-12-15 4:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 21:49 Pete Zaitcev
2005-12-12 21:53 ` Russell King
2005-12-14 5:50 ` Greg KH
2005-12-14 6:58 ` Pete Zaitcev
2005-12-14 23:26 ` Pete Zaitcev
2005-12-14 23:42 ` Greg KH
2005-12-15 0:10 ` Pete Zaitcev
2005-12-15 0:44 ` Greg KH
2005-12-15 2:47 ` Bill Nottingham
2005-12-15 4:47 ` Jeremy Katz [this message]
2005-12-15 16:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134622055.2864.21.camel@bree.local.net \
--to=katzj@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®