mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "K.R. Foley" <kr@cybsft.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.15-rc5-rt2 won't boot on dual 933
Date: Sun, 18 Dec 2005 19:51:13 -0500	[thread overview]
Message-ID: <1134953473.13138.217.camel@localhost.localdomain> (raw)
In-Reply-To: <43A5DAE4.8090908@cybsft.com>

On Sun, 2005-12-18 at 15:55 -0600, K.R. Foley wrote:
> dump_stack+0x1e/0x20 (20)
>  [<c011c9df>] preempt_enable_no_resched+0x5f/0x70 (20)
>  [<c0100ff2>] cpu_idle+0xb2/0x100 (40)
>  [<c0111446>] start_secondary+0x296/0x340<6> 

Ingo,

What's the reason for this printing out in cpu_idle?

#ifdef CONFIG_DEBUG_PREEMPT
void notrace preempt_enable_no_resched(void)
{
	static int once = 1;

	barrier();
	dec_preempt_count();

	if (once && !preempt_count()) {
		once = 0;
		printk(KERN_ERR "BUG: %s:%d task might have lost a preemption check!
\n",
			current->comm, current->pid);
		dump_stack();
	}
}

EXPORT_SYMBOL(preempt_enable_no_resched);
#endif

I can understand the above when using preempt_enable_no_resched, when
you know that you still have preemption on, but sometimes (as in
cpu_idle) it is used just before calling schedule.  So this check is
pretty much meaningless.

---

KR, 

Does your kernel boot without CONFIG_DEBUG_PREEMPT?

-- Steve



  reply	other threads:[~2005-12-19  0:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-18 21:55 K.R. Foley
2005-12-19  0:51 ` Steven Rostedt [this message]
2005-12-19  1:00   ` K.R. Foley
2005-12-19  1:59     ` Steven Rostedt
2005-12-19  2:11       ` K.R. Foley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1134953473.13138.217.camel@localhost.localdomain \
    --to=rostedt@goodmis.org \
    --cc=kr@cybsft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®