mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
	Andrew Morton <akpm@osdl.org>,
	Arjan van de Ven <arjanv@infradead.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Christoph Hellwig <hch@infradead.org>, Andi Kleen <ak@suse.de>,
	David Howells <dhowells@redhat.com>,
	Alexander Viro <viro@ftp.linux.org.uk>,
	Oleg Nesterov <oleg@tv-sign.ru>, Paul Jackson <pj@sgi.com>
Subject: Re: [patch 07/15] Generic Mutex Subsystem, mutex-debug-more.patch
Date: Mon, 19 Dec 2005 09:00:29 -0500	[thread overview]
Message-ID: <1135000829.13138.245.camel@localhost.localdomain> (raw)
In-Reply-To: <20051219013807.GC28038@elte.hu>

On Mon, 2005-12-19 at 02:38 +0100, Ingo Molnar wrote:
> Index: linux/lib/spinlock_debug.c
> ===================================================================
> --- linux.orig/lib/spinlock_debug.c
> +++ linux/lib/spinlock_debug.c
> @@ -20,7 +20,8 @@ static void spin_bug(spinlock_t *lock, c
>                 if (lock->owner && lock->owner != SPINLOCK_OWNER_INIT)
>                         owner = lock->owner;
>                 printk("BUG: spinlock %s on CPU#%d, %s/%d\n",
> -                       msg, smp_processor_id(), current->comm,
> current->pid);
> +                       msg, raw_smp_processor_id(),
> +                       current->comm, current->pid);
>                 printk(" lock: %p, .magic: %08x, .owner: %s/%
> d, .owner_cpu: %d\n",
>                         lock, lock->magic,
>                         owner ? owner->comm : "<none>",
> @@ -78,8 +79,8 @@ static void __spin_lock_debug(spinlock_t
>                 if (print_once) {
>                         print_once = 0;
>                         printk("BUG: spinlock lockup on CPU#%d, %s/%d,
> %p\n",
> -                               smp_processor_id(), current->comm,
> current->pid,
> -                                       lock);
> +                               raw_smp_processor_id(), current->comm,
> +                               current->pid, lock);
>                         dump_stack();
>                 }
>         }

The changes here from smp_processor_id to raw_smp_processor_id seem to
be more clean up and not part of the mutex patch.  Should these be sent
separately?

-- Steve



  reply	other threads:[~2005-12-19 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-19  1:38 Ingo Molnar
2005-12-19 14:00 ` Steven Rostedt [this message]
2005-12-19 17:00   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1135000829.13138.245.camel@localhost.localdomain \
    --to=rostedt@goodmis.org \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjanv@infradead.org \
    --cc=dhowells@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=pj@sgi.com \
    --cc=torvalds@osdl.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome