Re: [PATCH 2.6.15-rc6] block: Make CDROMEJECT more robust

[Ben Collins <ben.collins@ubuntu.com>]

On Mon, 2005-12-19 at 20:35 +0100, Jens Axboe wrote:
> On Mon, Dec 19 2005, Ben Collins wrote:
> > This patch fixes the WRITE vs READ issue, and also sends the extra two
> > commands. Anyone with an iPod connected via USB (not sure about firewire)
> > should be able to reproduce this issue, and verify the patch.
> 
> The bug was in the SCSI layer, and James already has the fix integrated
> for that. It really should make 2.6.15, James are you sending it upwards
> for that?

You mean this patch?

James Bottomley:
      [SCSI] Consolidate REQ_BLOCK_PC handling path (fix ipod panic)

This fixes an oops with data direction because sbp2 was not checking
enough itself.

I seriously doubt this will fix the issue being reported. Changing the
blk request to a READ did not fix the problem. The problem was only
fixed by sending the extra two commands. The direction was just a side
issue.

Is there a problem with sending the commands? If they don't bother
unaffected devices, but it does fix a large number of other devices,
what's the problem?

-- 
   Ben Collins <ben.collins@ubuntu.com>
   Developer
   Ubuntu Linux