From: Daniel Walker <dwalker@mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Subject: Re: [PATCH rc5-rt2 0/3] plist: alternative implementation
Date: Tue, 20 Dec 2005 08:34:21 -0800 [thread overview]
Message-ID: <1135096463.3834.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20051220143848.GA2053@elte.hu>
On Tue, 2005-12-20 at 15:38 +0100, Ingo Molnar wrote:
> * Oleg Nesterov <oleg@tv-sign.ru> wrote:
>
> > Rediff against patch-2.6.15-rc5-rt2.
> >
> > Nothing was changed except s/plist_next_entry/plist_first_entry/ to
> > match the current naming.
>
> thanks Oleg, your patches look good to me, and it's a worthwile cleanup
> to make plist.h ops behave more like normal list.h ops. The new ops
> should be documented, but otherwise it looks OK.
I think there is a bug in the new plist_add() , which was in the
original code. It doesn't properly handle the new maximum node scenario,
or INT_MAX .
If the list is 1 2 3 4
and you insert 5 , you'll end up with the list 1 2 3 5 4 . Or something
like that .
Daniel
next prev parent reply other threads:[~2005-12-20 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-18 18:17 Oleg Nesterov
2005-12-18 17:21 ` Steven Rostedt
2005-12-18 17:25 ` Steven Rostedt
2005-12-20 14:38 ` Ingo Molnar
2005-12-20 16:08 ` Oleg Nesterov
2005-12-20 15:04 ` Ingo Molnar
2005-12-20 16:11 ` Oleg Nesterov
2005-12-20 16:34 ` Daniel Walker [this message]
2005-12-20 18:31 ` Oleg Nesterov
2005-12-20 17:29 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135096463.3834.3.camel@localhost.localdomain \
--to=dwalker@mvista.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome