From: Yonghong Song <yhs@meta.com>
To: Peter Foley <pefoley2@pefoley.com>, Eduard Zingerman <eddyz87@gmail.com>
Cc: Quentin Monnet <quentin@isovalent.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev,
"Jose E. Marchesi" <jose.marchesi@oracle.com>
Subject: Re: [PATCH] tools: bpf: Disable stack protector
Date: Mon, 16 Jan 2023 23:05:15 -0800 [thread overview]
Message-ID: <1135125e-6b8a-7b75-5f0b-3208f6b6e8ae@meta.com> (raw)
In-Reply-To: <CAOFdcFOgAH1z7EKyM=Q4EvzLuKETOWWDMwuqp36SxV-X6PGP5Q@mail.gmail.com>
On 1/16/23 2:49 PM, Peter Foley wrote:
> On Mon, Jan 16, 2023 at 4:59 AM Eduard Zingerman <eddyz87@gmail.com> wrote:
>>
>> A bit tangential, but since BPF LLVM backend does not support the
>> stack protector (should it?) there is also an option to adjust LLVM
>> to avoid this instrumentation, WDYT?
>>
>
> That would probably be worth doing, yes.
> But given that won't help already released versions of clang, it
> should probably happen in addition to this patch.
Peter,
If I understand correctly (by inspecting clang code), the stack
protector is off by default. Do you have link to Gentoo build
page to show how they enable stack protector? cmake config or
a private patch?
Jose,
How gcc-bpf handle stack protector? The compiler just disables
stack protector for bpf target?
next prev parent reply other threads:[~2023-01-17 7:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 23:00 Peter Foley
2023-01-16 10:30 ` Quentin Monnet
2023-01-16 12:59 ` Eduard Zingerman
2023-01-16 22:49 ` Peter Foley
2023-01-16 22:53 ` Eduard Zingerman
2023-01-17 7:05 ` Yonghong Song [this message]
2023-01-17 7:09 ` Peter Foley
2023-01-17 16:22 ` Yonghong Song
2023-01-17 13:23 ` Jose E. Marchesi
2023-01-17 16:31 ` Jose E. Marchesi
2023-01-17 17:14 ` Yonghong Song
2023-01-17 17:11 ` Yonghong Song
2023-01-18 19:28 ` Eduard Zingerman
2023-01-19 7:34 ` Yonghong Song
2023-01-23 4:28 ` Peter Foley
2023-01-23 5:22 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135125e-6b8a-7b75-5f0b-3208f6b6e8ae@meta.com \
--to=yhs@meta.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jose.marchesi@oracle.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pefoley2@pefoley.com \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=trix@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®