From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764689AbdJQXAb convert rfc822-to-8bit (ORCPT ); Tue, 17 Oct 2017 19:00:31 -0400 Received: from mga01.intel.com ([192.55.52.88]:16865 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756912AbdJQXAa (ORCPT ); Tue, 17 Oct 2017 19:00:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,392,1503385200"; d="scan'208";a="1231943193" From: "Dilger, Andreas" To: "Gustavo A. R. Silva" CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 16/20] staging: lustre: lprocfs: mark expected switch fall-throughs Thread-Topic: [PATCH 16/20] staging: lustre: lprocfs: mark expected switch fall-throughs Thread-Index: AQHTQ3WnWHyb5pw8MU6YBNEUM33sXqLpJdyA Date: Tue, 17 Oct 2017 23:00:26 +0000 Message-ID: <113524DE-3EF5-4437-A1AF-93D5CCD85A93@intel.com> References: <734912e09d855035cfa64746101cc24b8695bf3e.1507781178.git.garsilva@embeddedor.com> In-Reply-To: <734912e09d855035cfa64746101cc24b8695bf3e.1507781178.git.garsilva@embeddedor.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.142.85] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1271166 > Addresses-Coverity-ID: 1271167 > Addresses-Coverity-ID: 1271168 > Addresses-Coverity-ID: 1271169 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > index e79485b..4ec582f 100644 > --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > @@ -1507,12 +1507,16 @@ int lprocfs_write_frac_u64_helper(const char __user *buffer, > switch (tolower(*end)) { > case 'p': > units <<= 10; > + /* fall through */ > case 't': > units <<= 10; > + /* fall through */ > case 'g': > units <<= 10; > + /* fall through */ > case 'm': > units <<= 10; > + /* fall through */ > case 'k': > units <<= 10; > } > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation