mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, inaky.perez-gonzalez@intel.com,
	tglx@linutronix.de, mingo@elte.hu
Subject: Re: [PATCH 02/02] RT: plist namespace cleanup
Date: Thu, 22 Dec 2005 09:28:51 -0800	[thread overview]
Message-ID: <1135272531.3696.12.camel@localhost.localdomain> (raw)
In-Reply-To: <43AAEF6E.47CCEFE0@tv-sign.ru>

On Thu, 2005-12-22 at 21:24 +0300, Oleg Nesterov wrote:
> Daniel Walker wrote:
> > 
> > On Thu, 2005-12-22 at 17:10 +0300, Oleg Nesterov wrote:
> > > Daniel Walker wrote:
> > > >
> > > >         Make the plist namespace consistent.
> > >
> > > I think plist_head is much better than pl_head.
> > >
> > > However I think plist_empty/plist_unhashed is more accurate
> > > than plist_head_empty/plist_node_empty, but I am rather
> > > agnostic to naming.
> > 
> > unhashed seems very meaningless . We're not hashing anything.
> 
> Still we already have hlist_empty/hlist_unhashed

That's more connected with hashing , since that's were it gets used. In
this case we're not hashing , or even related to hashing. 

> > > Daniel, it would be great if you can check that kernel/rt.o
> > > was not changed after rename (as it should be).
> > 
> > I didn't check, but I made no code changes so it should be any
> > different.
> 
> That is why I asked. It is very easy to make a mistake by accident
> while doing trivial changes, but it is not easy to notice.

I reviewed it prior to submitting it . 

Daniel


      reply	other threads:[~2005-12-22 17:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-21 21:57 Daniel Walker
2005-12-22 14:10 ` Oleg Nesterov
2005-12-22 16:53   ` Daniel Walker
2005-12-22 18:24     ` Oleg Nesterov
2005-12-22 17:28       ` Daniel Walker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1135272531.3696.12.camel@localhost.localdomain \
    --to=dwalker@mvista.com \
    --cc=inaky.perez-gonzalez@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®