From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: nfs invalidates lose pte dirty bits
Date: Fri, 23 Dec 2005 09:41:55 +0100 [thread overview]
Message-ID: <1135327315.8167.11.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20051223023603.GY9576@opteron.random>
On Fri, 2005-12-23 at 03:36 +0100, Andrea Arcangeli wrote:
> On Thu, Dec 22, 2005 at 06:30:49PM -0500, Trond Myklebust wrote:
> > See the latest git release where we introduce the nfs_sync_mapping()
> > helper.
>
> So you also still break completely with threaded programs, did you
> consider that while fixing the most obvious problem? Isn't that a
> problem too? What about my suggestion of invalidate_inode_clean_pages?
It is only a problem when doing mmap writes. In the case of ordinary
writes, NFS has to do its own tracking of dirty pages, and so it can
ensure that no race exists.
However if the user is doing mmap writes while the file is in the
process of being modified on the server, then they are doing something
wrong anyway. The small race between nfs_sync_mapping() and
invalidate_inode_pages2() is the least of their problems.
Cheers,
Trond
next prev parent reply other threads:[~2005-12-23 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-22 17:55 Andrea Arcangeli
2005-12-22 23:30 ` Trond Myklebust
2005-12-23 2:36 ` Andrea Arcangeli
2005-12-23 8:41 ` Trond Myklebust [this message]
2005-12-23 15:17 ` Andrea Arcangeli
2005-12-23 21:02 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135327315.8167.11.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®