From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sripathi Kodi <sripathik@in.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Problem due to removing ppc64 rtc.c?
Date: Tue, 27 Dec 2005 21:25:16 +1100 [thread overview]
Message-ID: <1135679117.4780.38.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.63.0512271505030.3537@sripathi.in.ibm.com>
On Tue, 2005-12-27 at 15:45 +0530, Sripathi Kodi wrote:
>
> Before your changes, rtc_ioctl was implemented in the PPC specific rtc.c and
> it used to call ppc_md.get_rtc_time for RTC_RD_TIME, which I think used to
> end up in rtas_get_rtc_time. After your changes, time is now read in
> rtc_get_rtc_time using CMOS_READ calls, which apparently is resulting in wrong
> values being read. I changed rtc_do_ioctl to make it call rtas_get_rtc_time
> for RTC_RD_TIME call and the problem went away.
>
> Have I missed something or does this need fixing? Do we really need a PPC
> specific rtc_ioctl call that calls into rtas_get_rtc_time?
I think the problem is that you still have CONFIG_RTC in your .config
instead of CONFIG_GEN_RTC
Ben.
next prev parent reply other threads:[~2005-12-27 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-27 10:15 Sripathi Kodi
2005-12-27 10:25 ` Benjamin Herrenschmidt [this message]
2005-12-27 10:49 ` Sripathi Kodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1135679117.4780.38.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sripathik@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®