From: Arjan van de Ven <arjan@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH] protect remove_proc_entry
Date: Sat, 31 Dec 2005 09:34:21 +0100 [thread overview]
Message-ID: <1136018061.2901.4.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0512310154190.5977@gandalf.stny.rr.com>
On Sat, 2005-12-31 at 01:58 -0500, Steven Rostedt wrote:
> On Fri, 30 Dec 2005, Andrew Morton wrote:
>
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> > >
> > > +static DEFINE_SPINLOCK(remove_proc_lock);
> > >
> >
> > I'll take a closer look at this next week.
> >
> > The official way of protecting the contents of a directory from concurrent
> > lookup or modification is to take its i_sem. But procfs is totally weird
> > and that approach may well not be practical here. We'd certainly prefer
> > not to rely upon lock_kernel().
> >
>
> Yeah, I thought about using the sem (or mutex ;) but remove_proc_entry is
> used so darn much around the kernel, I wasn't sure it's not used in irq
> context.
it can't be; "anything-VFS" like this can sleep if the file is busy etc
etc.
next prev parent reply other threads:[~2005-12-31 8:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-30 20:04 [Question] race condition with remove_proc_entry Steven Rostedt
2005-12-30 21:28 ` [PATCH] protect remove_proc_entry Steven Rostedt
2005-12-30 21:34 ` Daniel Walker
2005-12-30 21:55 ` Steven Rostedt
2005-12-30 21:55 ` Mitchell Blank Jr
2005-12-30 22:09 ` Steven Rostedt
2005-12-30 22:18 ` Steven Rostedt
2006-01-04 9:21 ` Andrew Morton
2006-01-04 12:18 ` Steven Rostedt
2006-01-05 1:48 ` Mitchell Blank Jr
2006-01-07 11:25 ` Andrew Morton
2005-12-30 22:11 ` Steven Rostedt
2005-12-30 23:46 ` Andrew Morton
2005-12-31 6:58 ` Steven Rostedt
2005-12-31 8:34 ` Arjan van de Ven [this message]
2005-12-31 8:53 ` Kirill Korotaev
2006-01-04 9:36 ` Andrew Morton
2006-01-04 11:27 ` Kirill Korotaev
2006-01-02 13:02 ` Steven Rostedt
2006-01-07 11:36 ` Andrew Morton
2006-01-07 12:04 ` Steven Rostedt
2006-01-09 19:16 ` Steven Rostedt
2006-01-10 0:59 ` Steven Rostedt
2006-01-10 1:05 ` Ingo Molnar
2006-01-10 13:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1136018061.2901.4.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®