From: Richard Purdie <rpurdie@rpsys.net>
To: Florin Malita <fmalita@gmail.com>
Cc: rmk+lkml@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PXA2xx: build PCMCIA as a module
Date: Wed, 04 Jan 2006 22:20:20 +0000 [thread overview]
Message-ID: <1136413220.9902.94.camel@localhost.localdomain> (raw)
In-Reply-To: <1136409389.14442.20.camel@scox.glenatl.glenayre.com>
On Wed, 2006-01-04 at 16:16 -0500, Florin Malita wrote:
> This patch adds support for building the PCMCIA driver for pxa2xx Sharp
> platforms as a module:
>
> 1) platform_scoop_config is currently declared in pxa2xx_sharpsl.c but
> referenced in the platform code - move the declaration in the platform
> code so pxa2xx_sharpsl.c can be built as a module.
> 2) export soc_common_drv_pcmcia_remove which is referenced in
> pxa2xx_base.c.
>
> Please apply.
>
> Signed-off-by: Florin Malita <fmalita@gmail.com>
NAK. This breaks poodle, tosa and collie who also use scoop and this
pcmcia driver. I'd suggest moving scoop_pcmcia_config to
arch/arm/common/scoop.c instead. Whilst this means scoop can't be a
module, the hardware isn't going to do much without it so I have no
objection to that.
Richard
next prev parent reply other threads:[~2006-01-04 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 21:16 Florin Malita
2006-01-04 22:20 ` Richard Purdie [this message]
2006-01-05 0:12 ` Florin Malita
2006-01-05 14:17 ` Florin Malita
2006-01-05 15:52 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1136413220.9902.94.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=fmalita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome