From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751131AbdHUFrT (ORCPT ); Mon, 21 Aug 2017 01:47:19 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:36462 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbdHUFrR (ORCPT ); Mon, 21 Aug 2017 01:47:17 -0400 Subject: Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, taeung@kosslab.kr, Namhyung Kim , Milian Wolff , Jiri Olsa References: <1503046028-5691-1-git-send-email-treeze.taeung@gmail.com> <20170818142314.GJ10891@kernel.org> From: Taeung Song Message-ID: <1136b710-2012-fc5b-cee6-7b4b82e742ba@gmail.com> Date: Mon, 21 Aug 2017 14:47:09 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170818142314.GJ10891@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/18/2017 11:23 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu: >> With a existing 't' hotkey, support the three view based on percent, >> total period and number of samples on the annotate TUI browser, >> circulating them like below: >> >> Percent -> Period -> Samples -> Percent ... >> >> Suggested-by: Namhyung Kim >> Cc: Milian Wolff >> Cc: Jiri Olsa >> Signed-off-by: Taeung Song >> --- > > Ok, here I removed this part, that is not documented in the patch nor in > the 'h' help screen, if you think it should be considered, please > resubmit it with a proper explanation: I'm really sorry. The case 'e' code is a residue.. I missed removing the code. Thank you for indicating my mistakes. Do I resend this patchkit based on your changes ? Or, will you modify it by yourself ? Thanks, Taeung > > diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c > index e82e6c5df83b..ba0aee576a2b 100644 > --- a/tools/perf/ui/browsers/annotate.c > +++ b/tools/perf/ui/browsers/annotate.c > @@ -921,12 +921,6 @@ static int annotate_browser__run(struct annotate_browser *browser, > annotate_browser__opts.show_total_period = true; > annotate_browser__update_addr_width(browser); > continue; > - case 'e': > - annotate_browser__opts.show_total_period = false; > - annotate_browser__opts.show_nr_samples = > - !annotate_browser__opts.show_nr_samples; > - annotate_browser__update_addr_width(browser); > - continue; > case K_LEFT: > case K_ESC: > case 'q': >