From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbdBFVas (ORCPT ); Mon, 6 Feb 2017 16:30:48 -0500 Received: from smtp-sh.infomaniak.ch ([128.65.195.4]:44872 "EHLO smtp-sh.infomaniak.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbdBFVar (ORCPT ); Mon, 6 Feb 2017 16:30:47 -0500 Subject: Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the library To: Daniel Borkmann , linux-kernel@vger.kernel.org References: <20170205231428.23846-1-mic@digikod.net> <20170205231428.23846-6-mic@digikod.net> <58989691.7060403@iogearbox.net> <5898CBEF.20201@iogearbox.net> Cc: netdev@vger.kernel.org, Alexei Starovoitov , Shuah Khan From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <1136c1a4-1a73-a419-5550-4ebd8aee9d25@digikod.net> Date: Mon, 6 Feb 2017 22:30:18 +0100 User-Agent: MIME-Version: 1.0 In-Reply-To: <5898CBEF.20201@iogearbox.net> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Otd08lEItf39hhpdDRwfhScQEKaFjurWd" X-Antivirus: Dr.Web (R) for Unix mail servers drweb plugin ver.6.0.2.8 X-Antivirus-Code: 0x100000 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Otd08lEItf39hhpdDRwfhScQEKaFjurWd Content-Type: multipart/mixed; boundary="bQawRxMqnpDhQ2D5UBPBao38K7DgTCgrV"; protected-headers="v1" From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= To: Daniel Borkmann , linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org, Alexei Starovoitov , Shuah Khan Message-ID: <1136c1a4-1a73-a419-5550-4ebd8aee9d25@digikod.net> Subject: Re: [PATCH net-next v1 6/7] bpf: Use the bpf_load_program() from the library References: <20170205231428.23846-1-mic@digikod.net> <20170205231428.23846-6-mic@digikod.net> <58989691.7060403@iogearbox.net> <5898CBEF.20201@iogearbox.net> In-Reply-To: <5898CBEF.20201@iogearbox.net> --bQawRxMqnpDhQ2D5UBPBao38K7DgTCgrV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 06/02/2017 20:18, Daniel Borkmann wrote: > On 02/06/2017 08:16 PM, Micka=C3=ABl Sala=C3=BCn wrote: >> On 06/02/2017 16:30, Daniel Borkmann wrote: >>> On 02/06/2017 12:14 AM, Micka=C3=ABl Sala=C3=BCn wrote: >>>> Replace bpf_prog_load() with bpf_load_program() calls. >>>> >>>> Use the tools include directory instead of the installed one to allo= w >>>> builds from other kernels. >>>> >>>> Signed-off-by: Micka=C3=ABl Sala=C3=BCn >>>> Cc: Alexei Starovoitov >>>> Cc: Daniel Borkmann >>>> Cc: Shuah Khan >>>> --- >>>> tools/testing/selftests/bpf/Makefile | 6 +++++- >>>> tools/testing/selftests/bpf/bpf_sys.h | 21 >>>> --------------------- >>>> tools/testing/selftests/bpf/test_tag.c | 6 ++++-- >>>> tools/testing/selftests/bpf/test_verifier.c | 8 +++++--- >>>> 4 files changed, 14 insertions(+), 27 deletions(-) >>> >>> No objections, but if so, can't we add the remaining missing >>> pieces to bpf lib, so we can remove bpf_sys.h altogether? >> >> OK, I'll send a new patch replacing bpf_sys.h entirely. >=20 > Sounds great, thanks! >=20 Do you prefer a big patch or one for each replaced function? --bQawRxMqnpDhQ2D5UBPBao38K7DgTCgrV-- --Otd08lEItf39hhpdDRwfhScQEKaFjurWd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEUysCyY8er9Axt7hqIt7+33O9apUFAliY6uoACgkQIt7+33O9 apVGIQf+PQi9gZUGXTqbZo8PO4uD/6agWUeiGfCwFk56+DGE06vNWvvU1vgZcGBT zvCt1rslw3EF4SSCbWwloUSKolLtIxB0DO/PiCLLPWa/+TdFHH+Twd+Fal1WNfC1 u+U5uGY8y+uB8eUzqdDOx5H+HtBBoyKF2vXjGWPtdomSN5FXc0njzbxiH0QR7SiW yJeTum7JqkEb1VY6SrrvkNlauXmqQFfPaeLlkjaaf4gyYdo9nnD9Wt8pfz9HxM5C ddnkSbvDoq+DR+DErMK2HumQ2QjYETHKhtR6FVdB6mV/DPXv8LuDxzDrYRtweCwM 3HH3L498FZinyA4L0G973v8gdnyTmw== =987W -----END PGP SIGNATURE----- --Otd08lEItf39hhpdDRwfhScQEKaFjurWd--