From: Paul Fulghum <paulkf@microgate.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] new tty buffering access fix
Date: Wed, 11 Jan 2006 18:27:12 -0600 [thread overview]
Message-ID: <1137025632.3113.18.camel@x2.pipehead.org> (raw)
In-Reply-To: <20060111160823.6bc95ab8.akpm@osdl.org>
On Wed, 2006-01-11 at 16:08 -0800, Andrew Morton wrote:
> Curious. How did this manage to sneak through without anyone noticing?
> Does tty_buffer_request_room() mostly work, or do only rarely-used drivers
> use it, or what?
At common speeds you never have more than one
buffer on the queue when the function in question is called.
So looking at the head is the same as looking at the tail.
In my recent testing, I cranked the speed up and at 460800bps
the queue became corrupted when more than one buffer was pending.
This is the important part of the patch.
With this patch, I've been running multiple devices (synclink_gt)
simultaneously on an SMP machine from 38400bps to 921600bps and
the new buffering is solid.
The part of the patch in flush_to_ldisc closes a tiny hole
where an ISR might access the queue tail after flush_to_ldisc
has removed it from the queue.
--
Paul Fulghum
Microgate Systems, Ltd
next prev parent reply other threads:[~2006-01-12 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-11 23:51 Paul Fulghum
2006-01-12 0:08 ` Andrew Morton
2006-01-12 0:27 ` Paul Fulghum [this message]
2006-01-12 0:37 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137025632.3113.18.camel@x2.pipehead.org \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome