From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.de>, Minchan Kim <minchan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [RFC PATCH v1 2/3] PM / Runtime: force memory allocation with no I/O during runtime_resume callbcack
Date: Fri, 19 Oct 2012 01:16:58 +0200 [thread overview]
Message-ID: <11374134.vToUn932b7@vostro.rjw.lan> (raw)
In-Reply-To: <CACVXFVP-JerxiTU9Kr9Lrwe2XkKBU=EsZJUcEiPVCQWw6iiw2Q@mail.gmail.com>
On Wednesday 17 of October 2012 19:07:25 Ming Lei wrote:
> On Wed, Oct 17, 2012 at 1:43 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >
> > This appears to be a bit too heavy handed. First of all, it seems to affect
> > all memory allocations going in parallel with the resume callback. Second,
>
> No, the flag is per task, only memory allocation inside resume callback
> is effected.
OK
> > it affects all resume callbacks, not only those where the problem really
>
> We can do it only on block device, block device's ancestor and network
> devices(iSCSI case), but that may introduce policy into PM core or add
> one flag of memalloc_noio_resume into 'dev_pm_info', could you agree
> on it?
Well, the question is how many runtime resume callbacks actually allocate
memory. If they are not too many, we can just flag all of them. Otherwise,
adding a flag may be a better approach. I'm not sure ATM.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2012-10-18 23:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 15:59 [RFC PATCH v1 0/3] mm/PM/USB: memory allocation with no io in need Ming Lei
2012-10-16 15:59 ` [RFC PATCH v1 1/3] mm: teach mm by current context info to not do I/O during memory allocation Ming Lei
2012-10-16 20:19 ` Andrew Morton
2012-10-17 1:54 ` Ming Lei
2012-10-17 23:54 ` Andrew Morton
2012-10-19 3:52 ` Ming Lei
2012-10-17 3:40 ` Ming Lei
2012-10-17 5:14 ` Kamezawa Hiroyuki
2012-10-17 10:56 ` Ming Lei
2012-10-16 15:59 ` [RFC PATCH v1 2/3] PM / Runtime: force memory allocation with no I/O during runtime_resume callbcack Ming Lei
2012-10-17 5:43 ` Rafael J. Wysocki
2012-10-17 11:07 ` Ming Lei
2012-10-18 23:16 ` Rafael J. Wysocki [this message]
2012-10-19 1:41 ` Ming Lei
2012-10-16 15:59 ` [RFC PATCH v1 3/3] USB: forbid memory allocation with I/O during bus reset Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11374134.vToUn932b7@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ming.lei@canonical.com \
--cc=oneukum@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®