From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Jason Baron <jbaron@redhat.com>,
mingo@elte.hu, linux-kernel@vger.kernel.org, drepper@redhat.com,
Tony.Reix@bull.net
Subject: Re: [2.6 patch] fix sched_setscheduler semantics
Date: Mon, 16 Jan 2006 22:57:46 +0000 [thread overview]
Message-ID: <1137452266.15553.89.camel@localhost.localdomain> (raw)
In-Reply-To: <20060116225215.GA11049@mipter.zuzino.mipt.ru>
On Maw, 2006-01-17 at 01:52 +0300, Alexey Dobriyan wrote:
> On Mon, Jan 16, 2006 at 05:17:55PM -0500, Jason Baron wrote:
> > --- linux-2.6/kernel/sched.c.bak
> > +++ linux-2.6/kernel/sched.c
> > @@ -3824,6 +3824,10 @@ do_sched_setscheduler(pid_t pid, int pol
> > asmlinkage long sys_sched_setscheduler(pid_t pid, int policy,
> > struct sched_param __user *param)
> > {
> > + /* negative values for policy are not valid */
> > + if (policy < 0)
> > + return -EINVAL;
>
> Classical redundant comment.
Disagree. A pointless comment would be "if policy is negative return
-EINVAL". The comment makes it clear that policy < 0 is *invalid* as a
syscall argument rather than just something not currently handled, or
being done for algorithmic reasons
next prev parent reply other threads:[~2006-01-16 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-16 22:17 Jason Baron
2006-01-16 22:52 ` Alexey Dobriyan
2006-01-16 22:57 ` Alan Cox [this message]
2006-01-17 7:59 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137452266.15553.89.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Tony.Reix@bull.net \
--cc=adobriyan@gmail.com \
--cc=drepper@redhat.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®