From: David Woodhouse <dwmw2@infradead.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: Fix regression added by ppoll/pselect code.
Date: Fri, 20 Jan 2006 17:48:06 +1300 [thread overview]
Message-ID: <1137732487.30084.194.camel@localhost.localdomain> (raw)
In-Reply-To: <20060119.164042.74751188.davem@davemloft.net>
On Thu, 2006-01-19 at 16:40 -0800, David S. Miller wrote:
> The two ROUND_UP() calls upon entry are using {tv,ts}_sec where it
> should instead be using {tv_usec,ts_nsec}, which perfectly explains
> the observed incorrect behavior.
Hm, I thought akpm had already fixed that -- but thanks.
His patch also changed the simple powers of ten to the slightly
confusing 'NSEC_PER_SEC' and 'USEC_PER_SEC' macros, as if those numbers
are subject to change by later decree, and shouldn't be hard-coded. I
suspect we can do without that part, although I don't really care either
way.
--
dwmw2
next prev parent reply other threads:[~2006-01-20 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-20 0:40 David S. Miller
2006-01-20 4:48 ` David Woodhouse [this message]
2006-01-20 4:56 ` Andrew Morton
2006-01-20 5:04 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137732487.30084.194.camel@localhost.localdomain \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®