From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751224AbdCQOKA (ORCPT ); Fri, 17 Mar 2017 10:10:00 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:36234 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbdCQOJE (ORCPT ); Fri, 17 Mar 2017 10:09:04 -0400 X-AuditID: b6c32a39-f799f6d000001a36-97-58cbedfce12d From: Bartlomiej Zolnierkiewicz To: Tejun Heo Cc: Russell King , Sergei Shtylyov , Sekhar Nori , Arnd Bergmann , Dmitry Eremin-Solenikov , Kevin Hilman , Olof Johansson , linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_pcmcia: add EBSA110's PCMCIA slot support Date: Fri, 17 Mar 2017 15:08:56 +0100 Message-id: <11380780.Ccg1NEX8q5@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170317133900.GA5078@htj.duckdns.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTcRjG+Z+zy3G1Os5lr5oJC5GkTMPodEG6KBwq0G9aYbXy6Eyna1PL KFLxkpLltXIo+sGKFiyb4m2oy8vUtPCejdSmliSYiCx1WqY7C/z2vO/743n+D/wJXGTguhLR cQmMMk4aK+EJOLVt+30Ors31hPm2F3tQfwqMfKpgeh6nVrJqMEo3NcKljPWTGDXYWMqjWnKr MOrD50UeNfAkH6N6NSY+ZX3VgU5towdH+nF61VqA6PnRDD79rXgdoxvUY3xap8nm0dWVD+ih rjQu3Tlah9GLur0hgkuCkxFMbHQSozwUcE0gGy6s5ChSBXfGVizcFLTEz0EEAaQ/dM+Jc5DD hnSGvvG3vBwkIERkPYLMxyYOO2RhkNP7nsNS/tC4ZrVTpQj0P60YO1gQFKXVYJsUjzwO+Vka tKnFpDsMPTWjTQgn1zHQNpl4mwcn8iwMDvyw2XJIT2heXrDthaQ3lNRV2Yx2keegpjnLph02 orXl6RyWcYTlwnGbxkkPaG4p5rL6AHw0am1hQE7yoT3bai/qDjoDzlYIhMq+TozVTjDbWcNn tRto/prs+2cI6laB9alGoNHn2aET0NbZbw/bAb8sj7isvxAeZopYhIam2SU7fhqKOtj3iMgX CCwzGl4e8lBv6aDe0kG9pUMFwjXImVGo5FGMyk9xxEcllasS46J8bsTLdcj2r7yP1SPjpwut iCSQZLtwdLonTMSVJqmS5a0ICFwiFgZNbKyEEdLku4wy/qoyMZZRtSI3giPZLeT65oeJyChp AhPDMApG+f+KEQ6uKei1103i3cXnYfGDhkZ91/eSmKHb4V7epoWqSO19WuAkLqkdD3epGC7O MDd75n4x+iiqFakhJUsTh5fKfIMdF4JCZTGyfddDzemXA5r0e6IMZeel8MbFPbmoVCKaahi6 UnaP9CqfC8275RZybufL37AOgV+DuwXmSMJ8RjsTd1TCUcmkft64UiX9B69kJUtTAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsVy+t9jQd3fb09HGDw5ymnxd9IxdotJT94z W/xs38JksenxNVaLYzseMVlc3jWHzWJ/7wYmi1PXP7NZXOqfyGRxZtUtdotfy48yOnB7XL52 kdnj969JjB7vb7SyezyY+p/JY+esu+wem1Z1snlsXlLvceVEE6vH8RvbmTw+b5IL4Ipys8lI TUxJLVJIzUvOT8nMS7dVCg1x07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2C W8bVyUtYChq5Ku7+/MrawPidvYuRk0NCwERi159fbBC2mMSFe+vBbCGBWYwSj3dFQthfGSXa vpaD2GwCVhIT21cxgtgiArISV6Y9BLK5OJgFGpklzvy+xQSSEBZwlrh86RkLiM0ioCqx78dH sKG8AloSM7dvAKsRFfCS2LKvHczmBDpi3fwWFohlyxkl/p0zh6gXlPgx+R5YnFlAXmLf/qms ELaWxPqdx5kmMAJdiVA2C0nZLCRlCxiZVzFKpBYkFxQnpeca5qWW6xUn5haX5qXrJefnbmIE x+4zqR2MB3e5H2IU4GBU4uG98eR0hBBrYllxZe4hRgkOZiURXtf7QCHelMTKqtSi/Pii0pzU 4kOMpkAPTmSWEk3OB6aVvJJ4QxNzE3NjAwtzS0sTIyVx3sbZz8KFBNITS1KzU1MLUotg+pg4 OKUaGNl+u9yrXrg4sL7iq3Ay78uwfTX/Hvz6a3mKd1/dzkNL5nie3HBs0z/xk6vTizYJ3s7c nMTy4OgXARbrQ0r3mwx6MoI1v02dYHZbXsmvo6ir48G0wKg3ZzufevTOL/gldOrlG5aHFf/T G29t+n1Af25clObx2+dEKmv5pWOPfDEuFFWJ2PL9eJcSS3FGoqEWc1FxIgDmiNsV8wIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170317140859epcas1p37f248662a9384e45d07983d7d694c3a1 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170314175046epcas1p43f98daad14a2bac7f314e7d39e120232 X-RootMTR: 20170314175046epcas1p43f98daad14a2bac7f314e7d39e120232 References: <1533391.BtkrkgvqUW@amdc3058> <20170317133900.GA5078@htj.duckdns.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, March 17, 2017 09:39:00 AM Tejun Heo wrote: > Hello, > > On Fri, Mar 17, 2017 at 12:59:56PM +0100, Bartlomiej Zolnierkiewicz wrote: > > There is no support for this device in the upstream ide driver but > > Russell has a hacky patch to make it work by redefining inb()/outb() > > operations globally for the whole ide subsystem, please see: > > > > https://www.spinics.net/lists/arm-kernel/msg567454.html > > Well, that mail says that the hardware is a museum piece. What's the > point here? This can't even be tested, can it? To be honest, the main point here is to make Russell happy. ;-) This is the second time he brought EBSA110 issue while talking about conversion of ARM platforms to use libata PATA so I've finally decided to do the patch just to have a reference example of how to deal with this and similar devices in a proper way. Even though the patch can't be tested EBSA110 is still a supported ARM platform and the patch should work fine in theory (+ it cannot break anything). OTOH it adds an extra code which has some cost from the long-term maintenance POV. Anyway, it is up to you to decide what to do with it. :-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics