mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg KH <greg@kroah.com>,
	Dmitry Torokhov <dtor_core@ameritech.net>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: uevent buffer overflow in input layer
Date: Wed, 25 Jan 2006 10:21:32 +1100	[thread overview]
Message-ID: <1138144893.4907.72.camel@localhost.localdomain> (raw)
In-Reply-To: <20060124105857.GA9210@vrfy.org>

The buffer used for kobject uevent is too small for some of the events generated
by the input layer. Bump it to 2k.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>


Index: linux-work/lib/kobject_uevent.c
===================================================================
--- linux-work.orig/lib/kobject_uevent.c	2006-01-11 12:56:30.000000000 +1100
+++ linux-work/lib/kobject_uevent.c	2006-01-25 10:20:24.000000000 +1100
@@ -22,7 +22,7 @@
 #include <linux/kobject.h>
 #include <net/sock.h>
 
-#define BUFFER_SIZE	1024	/* buffer for the variables */
+#define BUFFER_SIZE	2048	/* buffer for the variables */
 #define NUM_ENVP	32	/* number of env pointers */
 
 #if defined(CONFIG_HOTPLUG) && defined(CONFIG_NET)



      reply	other threads:[~2006-01-24 23:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-22 23:43 Benjamin Herrenschmidt
2006-01-24  5:03 ` Greg KH
2006-01-24  6:01   ` Dmitry Torokhov
2006-01-24  6:07     ` Greg KH
2006-01-24 10:58       ` Kay Sievers
2006-01-24 23:21         ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1138144893.4907.72.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=dtor_core@ameritech.net \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome