mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	Anton Blanchard <anton@samba.org>,
	David Ahern <daahern@cisco.com>,
	Paul Mackerras <paulus@samba.org>,
	Pekka Enberg <penberg@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 4/4] perf symbols: Increase symbol KSYM_NAME_LEN size
Date: Mon, 24 Oct 2011 14:05:12 -0400	[thread overview]
Message-ID: <11382.1319479512@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sun, 23 Oct 2011 17:12:23 -0200." <1319397143-20301-5-git-send-email-acme@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

On Sun, 23 Oct 2011 17:12:23 -0200, Arnaldo Carvalho de Melo said:

> Fglrx propietary driver has symbol names over 128 chars (:S). This
> breaks the function kallsyms__parse.

Well, that explains why they haven't upstreamed the driver, it will never
pass checkpatch's line-lenght check :)

But at some point you really need to just tell the vendors to put down
the crack pipe.

(What *are* the symbols? C++ mangled function names?)

[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2011-10-24 18:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-23 19:12 [GIT PULL 0/4] perf/core fixes and improvements Arnaldo Carvalho de Melo
2011-10-23 19:12 ` [PATCH 1/4] perf tools: Fix tracing info recording Arnaldo Carvalho de Melo
2011-10-23 19:12 ` [PATCH 2/4] perf ui browser: Use libslang to read keys Arnaldo Carvalho de Melo
2011-10-23 19:12 ` [PATCH 3/4] perf hists browser: Refuse 'a' hotkey on non symbolic views Arnaldo Carvalho de Melo
2011-10-23 19:12 ` [PATCH 4/4] perf symbols: Increase symbol KSYM_NAME_LEN size Arnaldo Carvalho de Melo
2011-10-24 18:05   ` Valdis.Kletnieks [this message]
2011-10-24 18:54     ` Ricardo Ribalda Delgado
2011-10-25  3:22 ` [GIT PULL 0/4] perf/core fixes and improvements Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11382.1319479512@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=anton@samba.org \
    --cc=daahern@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=penberg@kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®