From: doug thompson <dthompson@linuxnetworx.com>
To: Dave Peterson <dsp@llnl.gov>
Cc: "Eric W. Biederman" <ebiederman@lnxi.com>,
Gunther Mayer <gunther.mayer@gmx.net>,
"bluesmoke-devel@lists.sourceforge.net"
<bluesmoke-devel@lists.sourceforge.net>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC printk() cleanup
Date: Thu, 02 Feb 2006 09:16:53 -0700 [thread overview]
Message-ID: <1138897013.23854.34.camel@logos.linuxnetworx.com> (raw)
In-Reply-To: <200602011916.29281.dsp@llnl.gov>
On Wed, 2006-02-01 at 19:16 -0800, Dave Peterson wrote:
> On Monday 30 January 2006 19:22, Eric W. Biederman wrote:
> > One piece missing from this conversation is the issue that we need errors
> > in a uniform format. That is why edac_mc has helper functions.
> >
> > However there will always be errors that don't fit any particular model.
> > Could we add a edac_printk(dev, ); That is similar to dev_printk but
> > prints out an EDAC header and the device on which the error was found?
> > Letting the rest of the string be user specified.
> >
> > For actual control that interface may be to blunt, but at least for people
> > looking in the logs it allows all of the errors to be detected and
> > harvested.
>
> Ok, the patch below (which applies to the 2.6.16-rc1-git4 kernel) is
> an initial attempt at implementing this sort of thing. Here is some
> sample output (produced by loading the edac_mc and e7xxx_edac
> moules):
>
> EDAC MC: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c version edac_mc Ver: 2.0.0 Feb 1 2006
> EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_sysfs_memctrl_setup()
> EDAC DEBUG: Registered '.../edac/mc' kobject
> EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_sysfs_pci_setup()
> EDAC DEBUG: Registered '.../edac/pci' kobject
> EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/e7xxx_edac.c: e7xxx_init_one()
> EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/e7xxx_edac.c: e7xxx_probe1(): mci
> EDAC e7xxx: tolm = 40000, remapbase = ffc000, remaplimit = 0
> EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_mc_add_mc()
> EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_create_sysfs_mci_device() idx=0
> EDAC DEBUG: /tftpboot/dsp/printk/linux/drivers/edac/edac_mc.c: edac_create_csrow_object()
> EDAC DEBUG: Registered CSROW0
> EDAC MC0: Giving out device to e7xxx_edac E7500: PCI 0000:00:00.0
>
Yes, yes, yes
that is exactly what I had in mind. The old stuff bothered me something
bad, but I couldn't put my finger on exactly how to fix it yet - didn't
have the time.
It gives subsystem info (EDAC), modules therein, a bit of context then
event descriptions.
thanks dave and eric and good work
doug t
next prev parent reply other threads:[~2006-02-02 16:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 1:41 noisy edac Dave Jones
2006-01-29 21:52 ` Alan Cox
2006-01-29 23:42 ` Dave Jones
2006-01-30 18:59 ` Doug Thompson
2006-01-30 19:58 ` Dave Peterson
2006-01-30 21:04 ` doug thompson
2006-01-30 22:24 ` Dave Peterson
2006-01-30 23:44 ` Gunther Mayer
2006-01-30 23:52 ` Dave Peterson
2006-01-31 0:02 ` Gunther Mayer
2006-01-31 0:32 ` doug thompson
2006-01-31 4:09 ` Dave Peterson
2006-01-31 0:53 ` Dave Peterson
2006-01-31 3:22 ` Eric W. Biederman
2006-01-31 4:15 ` Dave Peterson
2006-01-31 16:34 ` doug thompson
2006-02-02 3:16 ` [PATCH] EDAC printk() cleanup Dave Peterson
2006-02-02 16:16 ` doug thompson [this message]
2006-01-31 3:28 ` noisy edac Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138897013.23854.34.camel@logos.linuxnetworx.com \
--to=dthompson@linuxnetworx.com \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=dsp@llnl.gov \
--cc=ebiederman@lnxi.com \
--cc=gunther.mayer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome