From: Eric Paris <eparis@redhat.com>
To: schwidefsky@de.ibm.com, linux390@de.ibm.com,
linux-390@vm.marist.edu, linux-kernel@vger.kernel.org
Subject: [PATCH] Style Fix in __constant_test_bit for S390, remove one set of ( )
Date: Thu, 02 Feb 2006 13:01:17 -0500 [thread overview]
Message-ID: <1138903277.16707.10.camel@localhost.localdomain> (raw)
Right now in __constant_test_bit for the s390 there is an extra set of
() surrounding the calculation. Putting it all on one line it could
read like
return (( ((volatile char *) addr) [(nr^(__BITOPS_WORDSIZE-8))>>3] & (1<<(nr&7)) )) != 0;
This patch simply removes one set of () that is surrounding the whole
clause.
Signed-off-by: Eric Paris <eparis@redhat.com>
---
bitops.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.15.2/include/asm-s390/bitops.h.old
+++ linux-2.6.15.2/include/asm-s390/bitops.h
@@ -518,8 +518,8 @@ static inline int __test_bit(unsigned lo
static inline int
__constant_test_bit(unsigned long nr, const volatile unsigned long *addr) {
- return ((((volatile char *) addr)
- [(nr^(__BITOPS_WORDSIZE-8))>>3] & (1<<(nr&7)))) != 0;
+ return (((volatile char *) addr)
+ [(nr^(__BITOPS_WORDSIZE-8))>>3] & (1<<(nr&7))) != 0;
}
#define test_bit(nr,addr) \
reply other threads:[~2006-02-02 18:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138903277.16707.10.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=linux-390@vm.marist.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®